Linux kernel staging patches
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Ignacio Peña" <ignacio.pena87@gmail.com>
Cc: linux-staging@lists.linux.dev
Subject: Re: [PATCH 3/3] staging: rtl8723bs: fix indentation in commented code
Date: Wed, 16 Jul 2025 09:38:18 +0200	[thread overview]
Message-ID: <2025071651-pulmonary-antirust-3abc@gregkh> (raw)
In-Reply-To: <20250716053604.64798-3-ignacio.pena87@gmail.com>

On Wed, Jul 16, 2025 at 01:36:04AM -0400, Ignacio Peña wrote:
> From: Ignacio Pena <ignacio.pena87@gmail.com>
> 
> Fix checkpatch warning by correcting tab indentation in commented
> return statement.
> 
> Signed-off-by: Ignacio Pena <ignacio.pena87@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index 437934dd2..f02b3b485 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -1318,7 +1318,7 @@ u8 rtw_lps_ctrl_wk_cmd(struct adapter *padapter, u8 lps_ctrl_type, u8 enqueue)
>         u8 res = _SUCCESS;
> 
>         /* if (!pwrctrlpriv->bLeisurePs) */
> -       /*      return res; */
> +       /*      return res; */

I don't see any whitespace change here as the whole patch's whitespace
is broken :(

Also, why not just delete these two lines entirely?

thanks,

greg k-h

  reply	other threads:[~2025-07-16  7:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-16  5:36 [PATCH 1/3] staging: rtl8723bs: fix block comment end markers Ignacio Peña
2025-07-16  5:36 ` [PATCH 2/3] staging: rtl8723bs: add missing blank line after declaration Ignacio Peña
2025-07-16  7:37   ` Greg KH
2025-07-16  5:36 ` [PATCH 3/3] staging: rtl8723bs: fix indentation in commented code Ignacio Peña
2025-07-16  7:38   ` Greg KH [this message]
2025-07-16  7:36 ` [PATCH 1/3] staging: rtl8723bs: fix block comment end markers Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025071651-pulmonary-antirust-3abc@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=ignacio.pena87@gmail.com \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox