Linux kernel staging patches
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Gopi <ggopijeganathan@gmail.com>
Cc: Dave Penkler <dpenkler@gmail.com>,
	Michael Rubin <matchstick@neverthere.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Dan Carpenter <dan.carpenter@linaro.org>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: gpib: Declare processor directive as CONFIG_TNT4882
Date: Tue, 9 Sep 2025 08:12:23 +0200	[thread overview]
Message-ID: <2025090940-backyard-mud-253a@gregkh> (raw)
In-Reply-To: <20250909041707.3001-1-ggopijeganathan@gmail.com>

On Tue, Sep 09, 2025 at 09:46:54AM +0530, Gopi wrote:
> Warning massage found by checkpatch.pl script.
> 
> Signed-off-by: Gopi <ggopijeganathan@gmail.com>
> ---
>  drivers/staging/gpib/tnt4882/tnt4882_gpib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/gpib/tnt4882/tnt4882_gpib.c b/drivers/staging/gpib/tnt4882/tnt4882_gpib.c
> index a17b69e34986..918a4cebbc6c 100644
> --- a/drivers/staging/gpib/tnt4882/tnt4882_gpib.c
> +++ b/drivers/staging/gpib/tnt4882/tnt4882_gpib.c
> @@ -1369,7 +1369,7 @@ static struct pci_driver tnt4882_pci_driver = {
>  	.probe = &tnt4882_pci_probe
>  };
>  
> -#if 0
> +#ifdef CONFIG_TNT4882

I do not understand, sorry, why is this the correct value to put here?

>  /* unused, will be needed when the driver is turned into a pnp_driver */
>  static const struct pnp_device_id tnt4882_pnp_table[] = {
>  	{.id = "NICC601"},

Now the code will not be unused, as you just enabled it?  Are you sure
the checkpatch warning was correct?

thanks,

greg k-h

  reply	other threads:[~2025-09-09  6:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-09  4:16 [PATCH] staging: gpib: Declare processor directive as CONFIG_TNT4882 Gopi
2025-09-09  6:12 ` Greg Kroah-Hartman [this message]
     [not found]   ` <CAGt2Sa+MriEYjPOFGmKWuHXabwkJeWn7q9o8U14B7o3QY4xmyg@mail.gmail.com>
     [not found]     ` <2025090945-ecologist-gravel-d028@gregkh>
     [not found]       ` <CAGt2Sa+tKAmxspYX=iyihmZYxWg0=xOJPW+J0h=9rTG8E99AAg@mail.gmail.com>
2025-09-09 14:40         ` Greg Kroah-Hartman
2025-09-09 14:48           ` Dave Penkler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025090940-backyard-mud-253a@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=dan.carpenter@linaro.org \
    --cc=dpenkler@gmail.com \
    --cc=ggopijeganathan@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=matchstick@neverthere.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox