Linux kernel staging patches
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: GOPI JEGANATHAN <ggopijeganathan@gmail.com>
Cc: Dave Penkler <dpenkler@gmail.com>,
	Michael Rubin <matchstick@neverthere.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Dan Carpenter <dan.carpenter@linaro.org>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: gpib: Declare processor directive as CONFIG_TNT4882
Date: Tue, 9 Sep 2025 16:40:08 +0200	[thread overview]
Message-ID: <2025090945-yearbook-busboy-2b28@gregkh> (raw)
In-Reply-To: <CAGt2Sa+tKAmxspYX=iyihmZYxWg0=xOJPW+J0h=9rTG8E99AAg@mail.gmail.com>

On Tue, Sep 09, 2025 at 07:56:07PM +0530, GOPI JEGANATHAN wrote:
> Hi Greg
> 
> I just saw the warning message in Checkpatch.pl file. It's says #if 0 is
> something wrong so I just change the processor directives properly using
> #ifdef CONFIG_TNT4882, Is that change is wrong!?

#if 0 is a way to comment out code, you just enabled that code to now be
present.  That's probably not the correct thing for this driver, right?
The whole thing is already using CONFIG_TNT4882, so declaring it again
would be the same as just removing the #if 0 line.

In short, only change this type of thing either by removing the code
entirely, or figuring out why it's still present and then fixing it up
to actually be used and remove the #if 0 lines.

thanks,

greg k-h

  parent reply	other threads:[~2025-09-09 14:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-09  4:16 [PATCH] staging: gpib: Declare processor directive as CONFIG_TNT4882 Gopi
2025-09-09  6:12 ` Greg Kroah-Hartman
     [not found]   ` <CAGt2Sa+MriEYjPOFGmKWuHXabwkJeWn7q9o8U14B7o3QY4xmyg@mail.gmail.com>
     [not found]     ` <2025090945-ecologist-gravel-d028@gregkh>
     [not found]       ` <CAGt2Sa+tKAmxspYX=iyihmZYxWg0=xOJPW+J0h=9rTG8E99AAg@mail.gmail.com>
2025-09-09 14:40         ` Greg Kroah-Hartman [this message]
2025-09-09 14:48           ` Dave Penkler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025090945-yearbook-busboy-2b28@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=dan.carpenter@linaro.org \
    --cc=dpenkler@gmail.com \
    --cc=ggopijeganathan@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=matchstick@neverthere.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox