From: Navaneeth K <knavaneeth786@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Navaneeth K <knavaneeth786@gmail.com>
Subject: [PATCH 1/5] staging: rtl8723bs: remove custom FIELD_OFFSET macro
Date: Sat, 22 Nov 2025 17:45:51 +0000 [thread overview]
Message-ID: <20251122174555.215109-2-knavaneeth786@gmail.com> (raw)
In-Reply-To: <20251122174555.215109-1-knavaneeth786@gmail.com>
The driver defined a custom macro FIELD_OFFSET which duplicates the
standard functionality of the kernel's offsetof() macro.
Remove the custom definition to clean up the code and rely on
standard kernel macros.
Signed-off-by: Navaneeth K <knavaneeth786@gmail.com>
---
drivers/staging/rtl8723bs/include/basic_types.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/basic_types.h b/drivers/staging/rtl8723bs/include/basic_types.h
index 1c2da18e6210..8adb95f9f1e5 100644
--- a/drivers/staging/rtl8723bs/include/basic_types.h
+++ b/drivers/staging/rtl8723bs/include/basic_types.h
@@ -12,8 +12,7 @@
#define FAIL (-1)
#include <linux/types.h>
-
-#define FIELD_OFFSET(s, field) ((__kernel_ssize_t)&((s *)(0))->field)
+#include <linux/stddef.h>
#define SIZE_PTR __kernel_size_t
#define SSIZE_PTR __kernel_ssize_t
--
2.43.0
next prev parent reply other threads:[~2025-11-22 17:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-22 17:45 [PATCH 0/5] staging: rtl8723bs: remove custom FIELD_OFFSET macro and dead code Navaneeth K
2025-11-22 17:45 ` Navaneeth K [this message]
2025-11-22 17:45 ` [PATCH 2/5] staging: rtl8723bs: replace FIELD_OFFSET usage with offsetof Navaneeth K
2025-11-24 8:08 ` Dan Carpenter
2025-11-24 9:17 ` david laight
2025-11-24 9:45 ` Dan Carpenter
2025-11-24 12:13 ` david laight
2025-11-24 13:07 ` Navaneeth K
2025-11-22 17:45 ` [PATCH 3/5] staging: rtl8723bs: use standard offsetof in cfg80211 operations Navaneeth K
2025-11-22 17:45 ` [PATCH 4/5] staging: rtl8723bs: remove dead code from odm.c Navaneeth K
2025-11-24 8:11 ` Dan Carpenter
2025-11-22 17:45 ` [PATCH 5/5] staging: rtl8723bs: use offsetof in rtw_mlme_ext.c Navaneeth K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251122174555.215109-2-knavaneeth786@gmail.com \
--to=knavaneeth786@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox