From: David Laight <david.laight.linux@gmail.com>
To: Preyas <preyas17@zohomail.in>
Cc: marvin24@gmx.de, gregkh@linuxfoundation.org,
ac100@lists.launchpad.net, linux-tegra@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: nvec: replace short udelay with usleep_range
Date: Sat, 20 Dec 2025 10:09:23 +0000 [thread overview]
Message-ID: <20251220100923.2a3de6db@pumpkin> (raw)
In-Reply-To: <20251220092229.16606-1-preyas17@zohomail.in>
On Sat, 20 Dec 2025 09:22:29 +0000
Preyas <preyas17@zohomail.in> wrote:
> From: Preyas Sharma <preyas17@zohomail.in>
>
> Signed-off-by: Preyas Sharma <preyas17@zohomail.in>
> ---
> drivers/staging/nvec/nvec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index 263774e6a78c..6ffe5e8656d1 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -648,7 +648,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
> break;
> case 2: /* first byte after command */
> if (status == (I2C_SL_IRQ | RNW | RCVD)) {
> - udelay(33);
> + usleep_range(33, 66);
Given its name the function looks like an ISR - where you can't sleep.
Spinning isn't a good idea either....
David
> if (nvec->rx->data[0] != 0x01) {
> dev_err(nvec->dev,
> "Read without prior read command\n");
next prev parent reply other threads:[~2025-12-20 10:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-20 9:22 [PATCH] staging: nvec: replace short udelay with usleep_range Preyas
2025-12-20 9:49 ` Greg KH
2025-12-20 10:09 ` David Laight [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-12-20 9:55 [PATCH] staging: av7110: use usleep_range for short waits Preyas
2025-12-20 9:55 ` [PATCH] staging: nvec: replace short udelay with usleep_range Preyas
2025-12-20 10:08 Preyas
2025-12-20 10:32 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251220100923.2a3de6db@pumpkin \
--to=david.laight.linux@gmail.com \
--cc=ac100@lists.launchpad.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=marvin24@gmx.de \
--cc=preyas17@zohomail.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox