From: Greg KH <gregkh@linuxfoundation.org>
To: Preyas <preyas17@zohomail.in>
Cc: marvin24@gmx.de, linux-tegra@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: nvec: replace short udelay with usleep_range
Date: Sat, 20 Dec 2025 11:32:57 +0100 [thread overview]
Message-ID: <2025122059-dipping-granola-74c5@gregkh> (raw)
In-Reply-To: <20251220100849.41214-1-preyas17@zohomail.in>
On Sat, Dec 20, 2025 at 10:08:20AM +0000, Preyas wrote:
> From: Preyas Sharma <preyas17@zohomail.in>
>
> Hi,
This isn't needed in a changelog, please read the documentation for how
to write a good changelog text.
> Replace udelay(33) with usleep_range(33, 66) in the nvec IRQ handler.
>
> This avoids busy-waiting while preserving the required delay for the
> first byte after a command, and follows guidance for microsecond-range
> waits.
What guidance? And why 66? Do you have the hardware to test this with?
And if you sleep, doesn't this get messed up?
Attempting to fix this checkpatch warning is almost always not a good
idea unless you have access to the hardware and the specs for it to
verify that this is an ok thing to do.
Please read the email archives for the many other times this has come
up for more details.
thanks,
greg k-h
next prev parent reply other threads:[~2025-12-20 10:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-20 10:08 [PATCH] staging: nvec: replace short udelay with usleep_range Preyas
2025-12-20 10:32 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-12-20 9:55 [PATCH] staging: av7110: use usleep_range for short waits Preyas
2025-12-20 9:55 ` [PATCH] staging: nvec: replace short udelay with usleep_range Preyas
2025-12-20 9:22 Preyas
2025-12-20 9:49 ` Greg KH
2025-12-20 10:09 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025122059-dipping-granola-74c5@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=marvin24@gmx.de \
--cc=preyas17@zohomail.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox