[PATCH] staging: rtl8723bs: avoid short msleep duration

[PATCH] staging: rtl8723bs: avoid short msleep duration

[Sun Jian]

msleep() is documented to sleep for at least the specified
number of milliseconds, but small values may result in a
longer delay due to scheduler granularity.

Replace msleep(10) with msleep(20) to match the effective
sleep duration and silence checkpatch warning.

No functional change intended.

Signed-off-by: Sun Jian <sun.jian.kdev@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index ef2d92b5588a..0edf9ecc4bed 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -215,7 +215,7 @@ void _rtw_free_evt_priv(struct	evt_priv *pevtpriv)
 {
 	_cancel_workitem_sync(&pevtpriv->c2h_wk);
 	while (pevtpriv->c2h_wk_alive)
-		msleep(10);
+		msleep(20);
 
 	while (!rtw_cbuf_empty(pevtpriv->c2h_queue)) {
 		void *c2h = rtw_cbuf_pop(pevtpriv->c2h_queue);
-- 
2.43.0

Re: [PATCH] staging: rtl8723bs: avoid short msleep duration

[Greg Kroah-Hartman]

On Sun, Dec 28, 2025 at 01:49:02PM +0800, Sun Jian wrote:
> msleep() is documented to sleep for at least the specified
> number of milliseconds, but small values may result in a
> longer delay due to scheduler granularity.
> 
> Replace msleep(10) with msleep(20) to match the effective
> sleep duration and silence checkpatch warning.
> 
> No functional change intended.
> 
> Signed-off-by: Sun Jian <sun.jian.kdev@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index ef2d92b5588a..0edf9ecc4bed 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -215,7 +215,7 @@ void _rtw_free_evt_priv(struct	evt_priv *pevtpriv)
>  {
>  	_cancel_workitem_sync(&pevtpriv->c2h_wk);
>  	while (pevtpriv->c2h_wk_alive)
> -		msleep(10);
> +		msleep(20);

That is very arbritrary, are you sure this is ok?  Why 20?

Just doing this for checkpatch without being able to test and know it
works properly on real hardware is not a good idea.

thanks,

greg k-h