[PATCH v2 0/4] staging: rtl8723bs: coding style fixes

[PATCH v2 0/4] staging: rtl8723bs: coding style fixes

[Nayana Mariyappa]

This is a series of 4 small coding style fixes for rtl8723bs. Each patch is
self-contained and focuses on a single logical change, as requested.

Changes since v1:
- Split the original patch into 4 separate patches.
- Each patch now fixes one coding style issue.

Patches in this series:

1/4 staging: rtl8723bs: fix block comment style
2/4 staging: rtl8723bs: remove extra blank lines
3/4 staging: rtl8723bs: add blank lines after declarations
4/4 staging: rtl8723bs: expand multiple assignment into separate statements

Signed-off-by: Nayana Mariyappa <nayana.mariyappa@gmail.com>

Re: [PATCH v2 0/4] staging: rtl8723bs: coding style fixes

[Greg Kroah-Hartman]

On Fri, Jan 09, 2026 at 11:04:16AM +0000, Nayana Mariyappa wrote:
> This is a series of 4 small coding style fixes for rtl8723bs. Each patch is
> self-contained and focuses on a single logical change, as requested.
> 
> Changes since v1:
> - Split the original patch into 4 separate patches.
> - Each patch now fixes one coding style issue.
> 
> Patches in this series:
> 
> 1/4 staging: rtl8723bs: fix block comment style
> 2/4 staging: rtl8723bs: remove extra blank lines
> 3/4 staging: rtl8723bs: add blank lines after declarations
> 4/4 staging: rtl8723bs: expand multiple assignment into separate statements
> 
> Signed-off-by: Nayana Mariyappa <nayana.mariyappa@gmail.com>
> 

Something went wrong with this submission, it seems to be broken up into
two "series".  Here's how it looks in my inbox:

      T Jan 09 Nayana Mariyapp (  16) [PATCH v2 0/4] staging: rtl8723bs: coding style fixes
      T Jan 09 Nayana Mariyapp (  31) └─>[PATCH v2 1/4] staging: rtl8723bs: fix block comment style
      T Jan 09 Nayana Mariyapp (  25) [PATCH v2 2/4] staging: rtl8723bs: remove extra blank lines
      T Jan 09 Nayana Mariyapp (  27) ├─>[PATCH v2 4/4] staging: rtl8723bs: expand multiple assignment into separate statements
      T Jan 09 Nayana Mariyapp (  25) └─>[PATCH v2 3/4] staging: rtl8723bs: add blank lines after declarations

And this also mirrors what shows up on lore.kernel.org:
	https://lore.kernel.org/r/20260109110417.16359-1-nayana.mariyappa@gmail.com

Can you fix up your git send-email settings to send these all out at once to
properly be linked together?

Thanks,

greg k-h

[PATCH v2 0/4] staging: rtl8723bs: coding style fixes

[Nayana Mariyappa]

This is a series of 4 small coding style fixes for rtl8723bs. Each patch is
self-contained and focuses on a single logical change, as requested.

Changes since v1:
- Split the original patch into 4 separate patches.
- Each patch now fixes one coding style issue.

Patches in this series:

1/4 staging: rtl8723bs: fix block comment style
2/4 staging: rtl8723bs: remove extra blank lines
3/4 staging: rtl8723bs: add blank lines after declarations
4/4 staging: rtl8723bs: expand multiple assignment into separate statements

Signed-off-by: Nayana Mariyappa <nayana.mariyappa@gmail.com>

[PATCH v2 1/4] staging: rtl8723bs: fix block comment style

[Nayana Mariyappa]

Fixed multi-line block comments in osdep_service.c to follow kernel
coding style.
No functional change.

Signed-off-by: Nayana Mariyappa <nayana.mariyappa@gmail.com>
---
 drivers/staging/rtl8723bs/os_dep/osdep_service.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/osdep_service.c b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
index a00f9f0c85c5..8f6dd3560303 100644
--- a/drivers/staging/rtl8723bs/os_dep/osdep_service.c
+++ b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
@@ -6,10 +6,10 @@
  ******************************************************************************/
 #include <drv_types.h>
 
-/*
-* Translate the OS dependent @param error_code to OS independent RTW_STATUS_CODE
-* @return: one of RTW_STATUS_CODE
-*/
+/**
+ * Translate the OS dependent @param error_code to OS independent RTW_STATUS_CODE
+ * @return: one of RTW_STATUS_CODE
+ */
 inline int RTW_STATUS_CODE(int error_code)
 {
 	if (error_code >= 0)
-- 
2.43.0

[PATCH v2 2/4] staging: rtl8723bs: remove extra blank lines

[Nayana Mariyappa]

Removed unnecessary blank lines in osdep_service.c and related files
to follow kernel coding style.
No functional change.

Signed-off-by: Nayana Mariyappa <nayana.mariyappa@gmail.com>
---
 drivers/staging/rtl8723bs/os_dep/osdep_service.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/osdep_service.c b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
index 8f6dd3560303..c9be4dc63598 100644
--- a/drivers/staging/rtl8723bs/os_dep/osdep_service.c
+++ b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
@@ -152,7 +152,6 @@ void rtw_buf_update(u8 **buf, u32 *buf_len, u8 *src, u32 src_len)
 		kfree(ori);
 }
 
-
 /**
  * rtw_cbuf_full - test if cbuf is full
  * @cbuf: pointer of struct rtw_cbuf
-- 
2.43.0

[PATCH v2 3/4] staging: rtl8723bs: add blank lines after declarations

[Nayana Mariyappa]

Added blank lines after variable declarations in osdep_service.c and related
files to improve readability and follow kernel coding style.
No functional change.

Signed-off-by: Nayana Mariyappa <nayana.mariyappa@gmail.com>
---
 drivers/staging/rtl8723bs/os_dep/osdep_service.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/rtl8723bs/os_dep/osdep_service.c b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
index c9be4dc63598..c490de437bf1 100644
--- a/drivers/staging/rtl8723bs/os_dep/osdep_service.c
+++ b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
@@ -203,6 +203,7 @@ bool rtw_cbuf_push(struct rtw_cbuf *cbuf, void *buf)
 void *rtw_cbuf_pop(struct rtw_cbuf *cbuf)
 {
 	void *buf;
+
 	if (rtw_cbuf_empty(cbuf))
 		return NULL;
 
-- 
2.43.0

[PATCH v2 4/4] staging: rtl8723bs: expand multiple assignment into separate statements

[Nayana Mariyappa]

Split multiple assignments in a single line into separate statements in
osdep_service.c to follow kernel coding style.
No functional change.

Signed-off-by: Nayana Mariyappa <nayana.mariyappa@gmail.com>
---
 drivers/staging/rtl8723bs/os_dep/osdep_service.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/osdep_service.c b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
index c490de437bf1..c082a0359064 100644
--- a/drivers/staging/rtl8723bs/os_dep/osdep_service.c
+++ b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
@@ -226,7 +226,8 @@ struct rtw_cbuf *rtw_cbuf_alloc(u32 size)
 	cbuf = rtw_malloc(struct_size(cbuf, bufs, size));
 
 	if (cbuf) {
-		cbuf->write = cbuf->read = 0;
+		cbuf->write = 0;
+		cbuf->read = 0;
 		cbuf->size = size;
 	}
 
-- 
2.43.0

Re: [PATCH v2 1/4] staging: rtl8723bs: fix block comment style

[Greg KH]

On Mon, Jan 12, 2026 at 04:34:26AM +0000, Nayana Mariyappa wrote:
> Fixed multi-line block comments in osdep_service.c to follow kernel
> coding style.
> No functional change.
> 
> Signed-off-by: Nayana Mariyappa <nayana.mariyappa@gmail.com>
> ---
>  drivers/staging/rtl8723bs/os_dep/osdep_service.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/os_dep/osdep_service.c b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
> index a00f9f0c85c5..8f6dd3560303 100644
> --- a/drivers/staging/rtl8723bs/os_dep/osdep_service.c
> +++ b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
> @@ -6,10 +6,10 @@
>   ******************************************************************************/
>  #include <drv_types.h>
>  
> -/*
> -* Translate the OS dependent @param error_code to OS independent RTW_STATUS_CODE
> -* @return: one of RTW_STATUS_CODE
> -*/
> +/**

Nit, this shouldn't be /**, but rather /* as before, as this is not a
valid kernel doc comment.

If you want to turn it into a kernel-doc statement, like I think
checkpatch is warning you about, then please do so, with the full
function name and arguments documented.  But I really doubt this is
needed at all, but rather this can just be a one line comment instead.

thanks,

greg k-h

Re: [PATCH v2 0/4] staging: rtl8723bs: coding style fixes

[Greg Kroah-Hartman]

On Mon, Jan 12, 2026 at 02:56:11PM +0530, Nayana Mariyappa wrote:
> On Mon, Jan 12, 2026 at 12:19 PM Greg Kroah-Hartman <
> gregkh@linuxfoundation.org> wrote:
> > For some reason you sent this only to me, which is a bit rude to
> > everyone else on the mailing list.  I'll be glad to respond if you
> > resend it to everyone.
> >
> > Also, do not top-post.
> 
> 
> Apologies for that -- this was unintentional.
> 
> I realized the issue was that the cover letter and patches were sent
> in multiple git send-email invocations. I have now resent the full
> series (0000–0004) in a single git send-email command, and it is visible
> on LKML/lore with proper threading.
> Sorry for the noise, and thanks for the guidance.

Great, but note, html emails are rejected by the lists :)

I've responded to one of your patches already, you'll need a new series.
And the one you just sent should have been v3, not v2, right?  So the
new one will be v4?

thanks,

greg k-h

Re: [PATCH v2 0/4] staging: rtl8723bs: coding style fixes

[Greg KH]

On Mon, Jan 12, 2026 at 04:34:25AM +0000, Nayana Mariyappa wrote:
> This is a series of 4 small coding style fixes for rtl8723bs. Each patch is
> self-contained and focuses on a single logical change, as requested.
> 
> Changes since v1:
> - Split the original patch into 4 separate patches.
> - Each patch now fixes one coding style issue.
> 
> Patches in this series:
> 
> 1/4 staging: rtl8723bs: fix block comment style
> 2/4 staging: rtl8723bs: remove extra blank lines
> 3/4 staging: rtl8723bs: add blank lines after declarations
> 4/4 staging: rtl8723bs: expand multiple assignment into separate statements
> 
> Signed-off-by: Nayana Mariyappa <nayana.mariyappa@gmail.com>
> 

This should have been v3, right?

thanks,

greg k-h

Re: [PATCH v2 0/4] staging: rtl8723bs: coding style fixes

[Nayana Mariyappa]

On Mon, Jan 12, 2026 at 3:03 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Mon, Jan 12, 2026 at 04:34:25AM +0000, Nayana Mariyappa wrote:
> > This is a series of 4 small coding style fixes for rtl8723bs. Each patch is
> > self-contained and focuses on a single logical change, as requested.
> >
> > Changes since v1:
> > - Split the original patch into 4 separate patches.
> > - Each patch now fixes one coding style issue.
> >
> > Patches in this series:
> >
> > 1/4 staging: rtl8723bs: fix block comment style
> > 2/4 staging: rtl8723bs: remove extra blank lines
> > 3/4 staging: rtl8723bs: add blank lines after declarations
> > 4/4 staging: rtl8723bs: expand multiple assignment into separate statements
> >
> > Signed-off-by: Nayana Mariyappa <nayana.mariyappa@gmail.com>
> >
>
> This should have been v3, right?
>
> thanks,
>
> greg k-h

Hi Greg,

You are correct, this should have been v3.

The non-kernel-doc comment was previously addressed as a separate
patch based on the kernel test robot report.
As part of this v4 series, that change has now been merged into the
0001 patch, so the separate bug-fix patch is retired.

All patches are sent together in a single series with proper threading
on LKML/lore.

Thanks,
Nayana Mariyappa