From: Greg KH <gregkh@linuxfoundation.org>
To: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
Cc: linux-staging@lists.linux.dev
Subject: Re: [PATCH 11/12] staging: rtl8723bs: remove unnecessary casts in rtl8723b_hal_init.c
Date: Thu, 26 Feb 2026 21:58:33 -0800 [thread overview]
Message-ID: <2026022618-unmoving-unpicked-b7d4@gregkh> (raw)
In-Reply-To: <20260226100255.167059-13-giorgitchankvetadze1997@gmail.com>
On Thu, Feb 26, 2026 at 02:02:55PM +0400, Giorgi Tchankvetadze wrote:
> Remove unnecessary pointer casts in memset(), memcpy(), and memcmp()
> calls. These functions accept void * arguments, so explicit casts
> are not needed.
>
> No functional change. Object code verified identical before and after.
>
> Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
> ---
> drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> index 8d259820f103..bc10f4aecda5 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> @@ -1185,12 +1185,14 @@ void Hal_InitPGData(struct adapter *padapter, u8 *PROMContent)
> if (!pEEPROM->EepromOrEfuse) {
> /* Read EFUSE real map to shadow. */
> EFUSE_ShadowMapUpdate(padapter, EFUSE_WIFI);
> - memcpy((void *)PROMContent, (void *)pEEPROM->efuse_eeprom_data, HWSET_MAX_SIZE_8723B);
> + memcpy(PROMContent, pEEPROM->efuse_eeprom_data,
> + HWSET_MAX_SIZE_8723B);
You wrapped the line which is not what the changelog said you were doing
:(
prev parent reply other threads:[~2026-02-27 5:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 10:02 [PATCH 11/12] staging: rtl8723bs: remove unnecessary casts in rtl8723b_hal_init.c Giorgi Tchankvetadze
2026-02-27 5:58 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026022618-unmoving-unpicked-b7d4@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=giorgitchankvetadze1997@gmail.com \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox