* [PATCH 11/12] staging: rtl8723bs: remove unnecessary casts in rtl8723b_hal_init.c
@ 2026-02-26 10:02 Giorgi Tchankvetadze
2026-02-27 5:58 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Giorgi Tchankvetadze @ 2026-02-26 10:02 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, Giorgi Tchankvetadze
Remove unnecessary pointer casts in memset(), memcpy(), and memcmp()
calls. These functions accept void * arguments, so explicit casts
are not needed.
No functional change. Object code verified identical before and after.
Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
---
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
index 8d259820f103..bc10f4aecda5 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
@@ -1185,12 +1185,14 @@ void Hal_InitPGData(struct adapter *padapter, u8 *PROMContent)
if (!pEEPROM->EepromOrEfuse) {
/* Read EFUSE real map to shadow. */
EFUSE_ShadowMapUpdate(padapter, EFUSE_WIFI);
- memcpy((void *)PROMContent, (void *)pEEPROM->efuse_eeprom_data, HWSET_MAX_SIZE_8723B);
+ memcpy(PROMContent, pEEPROM->efuse_eeprom_data,
+ HWSET_MAX_SIZE_8723B);
}
} else {/* autoload fail */
if (!pEEPROM->EepromOrEfuse)
EFUSE_ShadowMapUpdate(padapter, EFUSE_WIFI);
- memcpy((void *)PROMContent, (void *)pEEPROM->efuse_eeprom_data, HWSET_MAX_SIZE_8723B);
+ memcpy(PROMContent, pEEPROM->efuse_eeprom_data,
+ HWSET_MAX_SIZE_8723B);
}
}
--
2.52.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 11/12] staging: rtl8723bs: remove unnecessary casts in rtl8723b_hal_init.c
2026-02-26 10:02 [PATCH 11/12] staging: rtl8723bs: remove unnecessary casts in rtl8723b_hal_init.c Giorgi Tchankvetadze
@ 2026-02-27 5:58 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2026-02-27 5:58 UTC (permalink / raw)
To: Giorgi Tchankvetadze; +Cc: linux-staging
On Thu, Feb 26, 2026 at 02:02:55PM +0400, Giorgi Tchankvetadze wrote:
> Remove unnecessary pointer casts in memset(), memcpy(), and memcmp()
> calls. These functions accept void * arguments, so explicit casts
> are not needed.
>
> No functional change. Object code verified identical before and after.
>
> Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
> ---
> drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> index 8d259820f103..bc10f4aecda5 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> @@ -1185,12 +1185,14 @@ void Hal_InitPGData(struct adapter *padapter, u8 *PROMContent)
> if (!pEEPROM->EepromOrEfuse) {
> /* Read EFUSE real map to shadow. */
> EFUSE_ShadowMapUpdate(padapter, EFUSE_WIFI);
> - memcpy((void *)PROMContent, (void *)pEEPROM->efuse_eeprom_data, HWSET_MAX_SIZE_8723B);
> + memcpy(PROMContent, pEEPROM->efuse_eeprom_data,
> + HWSET_MAX_SIZE_8723B);
You wrapped the line which is not what the changelog said you were doing
:(
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-27 5:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-26 10:02 [PATCH 11/12] staging: rtl8723bs: remove unnecessary casts in rtl8723b_hal_init.c Giorgi Tchankvetadze
2026-02-27 5:58 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox