From: Greg KH <gregkh@linuxfoundation.org>
To: Lucas Faria Mendes <lucas.fariamo08@gmail.com>
Cc: ovidiu.panait.oss@gmail.com, linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: axis-fifo: fix alignment to match open parenthesis
Date: Fri, 27 Feb 2026 15:23:51 -0500 [thread overview]
Message-ID: <2026022711-showoff-bakery-8235@gregkh> (raw)
In-Reply-To: <20260227171746.24969-1-lucas.fariamo08@gmail.com>
On Fri, Feb 27, 2026 at 02:17:41PM -0300, Lucas Faria Mendes wrote:
> Fix checkpatch CHECK for alignment in the wait_event_interruptible()
> call. Align the continuation line to match the open parenthesis as
> required by the kernel coding style.
>
> Signed-off-by: Lucas Faria Mendes <lucas.fariamo08@gmail.com>
> ---
> drivers/staging/axis-fifo/axis-fifo.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
> index aa90b27197cf..c64a7249feca 100644
> --- a/drivers/staging/axis-fifo/axis-fifo.c
> +++ b/drivers/staging/axis-fifo/axis-fifo.c
> @@ -246,7 +246,8 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
> mutex_lock(&fifo->write_lock);
>
> ret = wait_event_interruptible(fifo->write_queue,
> - ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >= words_to_write);
> + ioread32(fifo->base_addr + XLLF_TDFV_OFFSET)
> + >= words_to_write);
Now it looks worse :(
This is one of those lines you just can not win, sorry, it keeps going
back and forth. Just leave it as is please.
thanks,
greg k-h
prev parent reply other threads:[~2026-02-27 20:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 17:17 [PATCH] staging: axis-fifo: fix alignment to match open parenthesis Lucas Faria Mendes
2026-02-27 20:23 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026022711-showoff-bakery-8235@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
--cc=lucas.fariamo08@gmail.com \
--cc=ovidiu.panait.oss@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox