Linux kernel staging patches
 help / color / mirror / Atom feed
* [PATCH] staging: axis-fifo: fix alignment to match open parenthesis
@ 2026-02-27 17:17 Lucas Faria Mendes
  2026-02-27 20:23 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Lucas Faria Mendes @ 2026-02-27 17:17 UTC (permalink / raw)
  To: gregkh, ovidiu.panait.oss; +Cc: linux-staging, Lucas Faria Mendes

Fix checkpatch CHECK for alignment in the wait_event_interruptible()
call. Align the continuation line to match the open parenthesis as
required by the kernel coding style.

Signed-off-by: Lucas Faria Mendes <lucas.fariamo08@gmail.com>
---
 drivers/staging/axis-fifo/axis-fifo.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
index aa90b27197cf..c64a7249feca 100644
--- a/drivers/staging/axis-fifo/axis-fifo.c
+++ b/drivers/staging/axis-fifo/axis-fifo.c
@@ -246,7 +246,8 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
 		mutex_lock(&fifo->write_lock);
 
 		ret = wait_event_interruptible(fifo->write_queue,
-			ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >= words_to_write);
+					       ioread32(fifo->base_addr + XLLF_TDFV_OFFSET)
+					       >= words_to_write);
 		if (ret)
 			goto end_unlock;
 	}
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: axis-fifo: fix alignment to match open parenthesis
  2026-02-27 17:17 [PATCH] staging: axis-fifo: fix alignment to match open parenthesis Lucas Faria Mendes
@ 2026-02-27 20:23 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2026-02-27 20:23 UTC (permalink / raw)
  To: Lucas Faria Mendes; +Cc: ovidiu.panait.oss, linux-staging

On Fri, Feb 27, 2026 at 02:17:41PM -0300, Lucas Faria Mendes wrote:
> Fix checkpatch CHECK for alignment in the wait_event_interruptible()
> call. Align the continuation line to match the open parenthesis as
> required by the kernel coding style.
> 
> Signed-off-by: Lucas Faria Mendes <lucas.fariamo08@gmail.com>
> ---
>  drivers/staging/axis-fifo/axis-fifo.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
> index aa90b27197cf..c64a7249feca 100644
> --- a/drivers/staging/axis-fifo/axis-fifo.c
> +++ b/drivers/staging/axis-fifo/axis-fifo.c
> @@ -246,7 +246,8 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
>  		mutex_lock(&fifo->write_lock);
>  
>  		ret = wait_event_interruptible(fifo->write_queue,
> -			ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >= words_to_write);
> +					       ioread32(fifo->base_addr + XLLF_TDFV_OFFSET)
> +					       >= words_to_write);

Now it looks worse :(

This is one of those lines you just can not win, sorry, it keeps going
back and forth.  Just leave it as is please.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-02-27 20:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-27 17:17 [PATCH] staging: axis-fifo: fix alignment to match open parenthesis Lucas Faria Mendes
2026-02-27 20:23 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox