* [PATCH] staging: axis-fifo: remove redundant comments for mutex fields
@ 2026-03-20 4:40 Zile Xiong
2026-03-20 9:35 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Zile Xiong @ 2026-03-20 4:40 UTC (permalink / raw)
To: gregkh; +Cc: ovidiu.panait.oss, linux-staging, linux-kernel, Zile Xiong
Remove redundant comments for read_lock and write_lock, as the
field names already clearly describe their purpose.
Signed-off-by: Zile Xiong <xiongzile99@gmail.com>
---
drivers/staging/axis-fifo/axis-fifo.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
index 3aa2aa870ea9..ad98d5eb7751 100644
--- a/drivers/staging/axis-fifo/axis-fifo.c
+++ b/drivers/staging/axis-fifo/axis-fifo.c
@@ -75,9 +75,9 @@ struct axis_fifo {
u32 has_tx_fifo;
wait_queue_head_t read_queue;
- struct mutex read_lock; /* lock for reading */
+ struct mutex read_lock;
wait_queue_head_t write_queue;
- struct mutex write_lock; /* lock for writing */
+ struct mutex write_lock;
struct device *dt_device;
struct miscdevice miscdev;
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: axis-fifo: remove redundant comments for mutex fields
2026-03-20 4:40 [PATCH] staging: axis-fifo: remove redundant comments for mutex fields Zile Xiong
@ 2026-03-20 9:35 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2026-03-20 9:35 UTC (permalink / raw)
To: Zile Xiong; +Cc: gregkh, ovidiu.panait.oss, linux-staging, linux-kernel
On Fri, Mar 20, 2026 at 12:40:40PM +0800, Zile Xiong wrote:
> Remove redundant comments for read_lock and write_lock, as the
> field names already clearly describe their purpose.
>
> Signed-off-by: Zile Xiong <xiongzile99@gmail.com>
You're not wrong, but this introduces a checkpatch warning so we
can't accept it either.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-20 9:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-20 4:40 [PATCH] staging: axis-fifo: remove redundant comments for mutex fields Zile Xiong
2026-03-20 9:35 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox