public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Nikolay Kulikov <nikolayof23@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, Nikolay Kulikov <nikolayof23@gmail.com>
Subject: [PATCH 10/11] staging: rtl8723bs: rename EnableInterrupt8723BSdio() to snake_case
Date: Sun, 19 Apr 2026 10:19:36 +0300	[thread overview]
Message-ID: <20260419072034.19824-11-nikolayof23@gmail.com> (raw)
In-Reply-To: <20260419072034.19824-1-nikolayof23@gmail.com>

Rename function EnableInterrupt8723BSdio() to
rtw_sdio_enable_interrupt() and format its description to comply with
Linux kernel coding style.
Declare this function without 'extern' prototype in the .h file to fix
checkpatch.pl warning.

Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
---
 drivers/staging/rtl8723bs/hal/sdio_ops.c     | 19 ++++++++-----------
 drivers/staging/rtl8723bs/include/sdio_ops.h |  2 +-
 drivers/staging/rtl8723bs/os_dep/sdio_intf.c |  2 +-
 3 files changed, 10 insertions(+), 13 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c
index 8cece69dbf79..0d8d0935e4a2 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_ops.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c
@@ -712,17 +712,14 @@ void InitSysInterrupt8723BSdio(struct adapter *adapter)
 	haldata->SysIntrMask = (0);
 }
 
-/*  */
-/*	Description: */
-/*		Enalbe SDIO Host Interrupt Mask configuration on SDIO local domain. */
-/*  */
-/*	Assumption: */
-/*		1. Using SDIO Local register ONLY for configuration. */
-/*		2. PASSIVE LEVEL */
-/*  */
-/*	Created by Roger, 2011.02.11. */
-/*  */
-void EnableInterrupt8723BSdio(struct adapter *adapter)
+/*
+ * Enable SDIO Host Interrupt Mask configuration on SDIO local domain.
+ *
+ * Assumption:
+ *	1. Using SDIO Local register ONLY for configuration.
+ *	2. PASSIVE LEVEL
+ */
+void rtw_sdio_enable_interrupt(struct adapter *adapter)
 {
 	struct hal_com_data *haldata;
 	__le32 himr;
diff --git a/drivers/staging/rtl8723bs/include/sdio_ops.h b/drivers/staging/rtl8723bs/include/sdio_ops.h
index c7559a884608..7bb4b2047cc1 100644
--- a/drivers/staging/rtl8723bs/include/sdio_ops.h
+++ b/drivers/staging/rtl8723bs/include/sdio_ops.h
@@ -27,7 +27,7 @@ extern u8 CheckIPSStatus(struct adapter *padapter);
 
 extern void InitInterrupt8723BSdio(struct adapter *padapter);
 extern void InitSysInterrupt8723BSdio(struct adapter *padapter);
-extern void EnableInterrupt8723BSdio(struct adapter *padapter);
+void rtw_sdio_enable_interrupt(struct adapter *padapter);
 extern void DisableInterrupt8723BSdio(struct adapter *padapter);
 extern u8 HalQueryTxBufferStatus8723BSdio(struct adapter *padapter);
 extern void HalQueryTxOQTBufferStatus8723BSdio(struct adapter *padapter);
diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
index a462a2864a59..f6fa51f952e0 100644
--- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
+++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
@@ -204,7 +204,7 @@ static void sd_intf_start(struct adapter *padapter)
 	if (!padapter)
 		return;
 
-	EnableInterrupt8723BSdio(padapter);
+	rtw_sdio_enable_interrupt(padapter);
 }
 
 static void sd_intf_stop(struct adapter *padapter)
-- 
2.53.0


  parent reply	other threads:[~2026-04-19  7:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-19  7:19 [PATCH 00/11] staging: rtl8723bs: cleanup hal/hal_intf.c Nikolay Kulikov
2026-04-19  7:19 ` [PATCH 01/11] staging: rtl8723bs: remove wrapper rtw_hal_chip_configure() Nikolay Kulikov
2026-04-19  7:19 ` [PATCH 02/11] staging: rtl8723bs: remove wrapper rtw_hal_read_chip_info() Nikolay Kulikov
2026-04-19  7:19 ` [PATCH 03/11] staging: rtl8723bs: remove wrapper rtw_hal_read_chip_version() Nikolay Kulikov
2026-04-19  7:19 ` [PATCH 04/11] staging: rtl8723bs: remove wrapper rtw_hal_def_value_init() Nikolay Kulikov
2026-04-19  7:19 ` [PATCH 05/11] staging: rtl8723bs: remove wrapper rtw_hal_free_data() Nikolay Kulikov
2026-04-19  7:19 ` [PATCH 06/11] staging: rtl8723bs: remove wrapper rtw_hal_dm_init() Nikolay Kulikov
2026-04-19  7:19 ` [PATCH 07/11] staging: rtl8723bs: remove wrapper rtw_hal_enable_interrupt() Nikolay Kulikov
2026-04-19  7:19 ` [PATCH 08/11] staging: rtl8723bs: remove wrapper rtw_hal_disable_interrupt() Nikolay Kulikov
2026-04-19  7:19 ` [PATCH 09/11] staging: rtl8723bs: rename ReadAdapterInfo8723BS() to snake_case Nikolay Kulikov
2026-04-19  7:19 ` Nikolay Kulikov [this message]
2026-04-19  7:19 ` [PATCH 11/11] staging: rtl8723bs: rename DisableInterrupt8723BSdio() " Nikolay Kulikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260419072034.19824-11-nikolayof23@gmail.com \
    --to=nikolayof23@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox