From: Nikolay Kulikov <nikolayof23@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, Nikolay Kulikov <nikolayof23@gmail.com>
Subject: [PATCH 03/11] staging: rtl8723bs: remove wrapper rtw_hal_read_chip_version()
Date: Sun, 19 Apr 2026 10:19:29 +0300 [thread overview]
Message-ID: <20260419072034.19824-4-nikolayof23@gmail.com> (raw)
In-Reply-To: <20260419072034.19824-1-nikolayof23@gmail.com>
Remove rtw_hal_read_chip_version() function, as it's just a wrapper
that calls rtl8723b_read_chip_version() directly. Replace all its calls
to the rtl8723b_read_chip_version(). This will remove an extra level of
abstraction and simplify the code.
Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
---
drivers/staging/rtl8723bs/hal/hal_intf.c | 5 -----
drivers/staging/rtl8723bs/include/hal_intf.h | 2 --
drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 2 +-
3 files changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl8723bs/hal/hal_intf.c
index da250179fc92..c3a238cb0b1e 100644
--- a/drivers/staging/rtl8723bs/hal/hal_intf.c
+++ b/drivers/staging/rtl8723bs/hal/hal_intf.c
@@ -7,11 +7,6 @@
#include <drv_types.h>
#include <hal_data.h>
-void rtw_hal_read_chip_version(struct adapter *padapter)
-{
- rtl8723b_read_chip_version(padapter);
-}
-
void rtw_hal_def_value_init(struct adapter *padapter)
{
rtl8723bs_init_default_value(padapter);
diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging/rtl8723bs/include/hal_intf.h
index 8f5f2c63fc10..0d2f60ce29af 100644
--- a/drivers/staging/rtl8723bs/include/hal_intf.h
+++ b/drivers/staging/rtl8723bs/include/hal_intf.h
@@ -195,8 +195,6 @@ void rtw_hal_get_hwreg(struct adapter *padapter, u8 variable, u8 *val);
void rtw_hal_set_hwreg_with_buf(struct adapter *padapter, u8 variable, u8 *pbuf, int len);
-void rtw_hal_read_chip_version(struct adapter *padapter);
-
u8 rtw_hal_get_def_var(struct adapter *padapter, enum hal_def_variable eVariable, void *pValue);
void rtw_hal_set_odm_var(struct adapter *padapter, enum hal_odm_variable eVariable, void *pValue1, bool bSet);
diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
index 98eff17be9b6..e487e238d737 100644
--- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
+++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
@@ -264,7 +264,7 @@ static struct adapter *rtw_sdio_if1_init(struct dvobj_priv *dvobj, const struct
if (rtw_init_io_priv(padapter, sdio_set_intf_ops) == _FAIL)
goto free_hal_data;
- rtw_hal_read_chip_version(padapter);
+ rtl8723b_read_chip_version(padapter);
rtl8723bs_interface_configure(padapter);
--
2.53.0
next prev parent reply other threads:[~2026-04-19 7:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-19 7:19 [PATCH 00/11] staging: rtl8723bs: cleanup hal/hal_intf.c Nikolay Kulikov
2026-04-19 7:19 ` [PATCH 01/11] staging: rtl8723bs: remove wrapper rtw_hal_chip_configure() Nikolay Kulikov
2026-04-19 7:19 ` [PATCH 02/11] staging: rtl8723bs: remove wrapper rtw_hal_read_chip_info() Nikolay Kulikov
2026-04-19 7:19 ` Nikolay Kulikov [this message]
2026-04-19 7:19 ` [PATCH 04/11] staging: rtl8723bs: remove wrapper rtw_hal_def_value_init() Nikolay Kulikov
2026-04-19 7:19 ` [PATCH 05/11] staging: rtl8723bs: remove wrapper rtw_hal_free_data() Nikolay Kulikov
2026-04-19 7:19 ` [PATCH 06/11] staging: rtl8723bs: remove wrapper rtw_hal_dm_init() Nikolay Kulikov
2026-04-19 7:19 ` [PATCH 07/11] staging: rtl8723bs: remove wrapper rtw_hal_enable_interrupt() Nikolay Kulikov
2026-04-19 7:19 ` [PATCH 08/11] staging: rtl8723bs: remove wrapper rtw_hal_disable_interrupt() Nikolay Kulikov
2026-04-19 7:19 ` [PATCH 09/11] staging: rtl8723bs: rename ReadAdapterInfo8723BS() to snake_case Nikolay Kulikov
2026-04-19 7:19 ` [PATCH 10/11] staging: rtl8723bs: rename EnableInterrupt8723BSdio() " Nikolay Kulikov
2026-04-19 7:19 ` [PATCH 11/11] staging: rtl8723bs: rename DisableInterrupt8723BSdio() " Nikolay Kulikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260419072034.19824-4-nikolayof23@gmail.com \
--to=nikolayof23@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox