From: Debjeet Banerjee <debjeetbanerjee48@gmail.com>
To: sakari.ailus@linux.intel.com
Cc: andy.shevchenko@gmail.com, andy@kernel.org,
debjeetbanerjee48@gmail.com, gregkh@linuxfoundation.org,
hansg@kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
mchehab@kernel.org
Subject: [PATCH v4 1/2] media: atomisp: csi2: Remove unimplemented DPCM decompression
Date: Wed, 22 Apr 2026 17:50:05 +0530 [thread overview]
Message-ID: <20260422122006.29390-1-debjeetbanerjee48@gmail.com> (raw)
In-Reply-To: <aeiuhvqcT189lL5U@kekkonen.localdomain>
The source pad format handling attempted to map DPCM-compressed mbus
codes to their uncompressed equivalents. However, the rest of the
driver does not support DPCM decompression, making this dead code.
Remove the DPCM unmapping logic and simplify to directly copy the sink
pad format to the source pad. Add an explicit comment stating that
DPCM is not supported.
Signed-off-by: Debjeet Banerjee <debjeetbanerjee48@gmail.com>
---
v4:
- Complete removal of DPCM decompression attempt (per Sakari Ailus feedback)
- Keep source pad simply copying sink pad format without unmapping
- Replace detailed comment with explicit "DPCM is not supported" statement
v3:
- Drop "staging:" prefix in subject (per Andy Shevchenko)
v2:
- Rebased onto latest media tree (fix CI apply failure)
- Fix missing linux-staging recipient (typo in v1)
- Fix indentation
---
drivers/staging/media/atomisp/pci/atomisp_csi2.c | 15 ++++-----------
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp_csi2.c b/drivers/staging/media/atomisp/pci/atomisp_csi2.c
index e723304bec80..64419c1a805e 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_csi2.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_csi2.c
@@ -107,17 +107,10 @@ int atomisp_csi2_set_ffmt(struct v4l2_subdev *sd,
&tmp_ffmt);
}
- /*
- * The source pad must expose the uncompressed format even when the sink
- * pad receives DPCM-compressed data. The hardware decompresses DPCM
- * (e.g. SGRBG10_DPCM8_1X8 -> SGRBG10_1X10) between sink and source,
- * so propagate the sink format but map the mbus code to its uncompressed
- * equivalent. atomisp_subdev_uncompressed_code() returns the code
- * unchanged for formats that are not DPCM-compressed.
- */
- *actual_ffmt = *__csi2_get_format(csi2, sd_state, which, CSI2_PAD_SINK);
- actual_ffmt->code = atomisp_subdev_uncompressed_code(actual_ffmt->code);
- *ffmt = *actual_ffmt;
+ /* Source pad format is copied from sink pad. DPCM is not supported. */
+ *actual_ffmt = *ffmt = *__csi2_get_format(csi2, sd_state, which,
+ CSI2_PAD_SINK);
+
return 0;
}
--
2.53.0
next prev parent reply other threads:[~2026-04-22 12:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260420032701.33250-1-debjeetbanerjee48@gmail.com>
2026-04-20 4:34 ` [PATCH v2] staging: media: atomisp: csi2: Fix DPCM decompression for source pad format Debjeet Banerjee
2026-04-20 6:46 ` Andy Shevchenko
2026-04-20 7:42 ` Debjeet Banerjee
2026-04-21 8:22 ` [PATCH v3] " Debjeet Banerjee
2026-04-22 10:46 ` Sakari Ailus
2026-04-22 11:16 ` Debjeet Banerjee
2026-04-22 11:18 ` Sakari Ailus
2026-04-22 12:20 ` Debjeet Banerjee [this message]
2026-04-22 12:20 ` [PATCH v4 2/2] media: atomisp: Remove unused DPCM helper functions and declarations Debjeet Banerjee
2026-04-22 12:38 ` [PATCH v4 1/2] media: atomisp: csi2: Remove unimplemented DPCM decompression Sakari Ailus
2026-04-22 12:48 ` [PATCH v3] media: atomisp: csi2: Fix DPCM decompression for source pad format Debjeet Banerjee
2026-04-22 12:51 ` [PATCH v4 1/2] media: atomisp: csi2: Remove unimplemented DPCM decompression Debjeet Banerjee
2026-04-22 12:58 ` Sakari Ailus
2026-04-22 13:38 ` Debjeet Banerjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260422122006.29390-1-debjeetbanerjee48@gmail.com \
--to=debjeetbanerjee48@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox