From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Debjeet Banerjee <debjeetbanerjee48@gmail.com>
Cc: andy.shevchenko@gmail.com, andy@kernel.org,
gregkh@linuxfoundation.org, hansg@kernel.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev, mchehab@kernel.org
Subject: Re: [PATCH v3] media: atomisp: csi2: Fix DPCM decompression for source pad format
Date: Wed, 22 Apr 2026 14:18:30 +0300 [thread overview]
Message-ID: <aeiuhvqcT189lL5U@kekkonen.localdomain> (raw)
In-Reply-To: <20260422111649.9604-1-debjeetbanerjee48@gmail.com>
Hi Dabjeet,
On Wed, Apr 22, 2026 at 04:46:49PM +0530, Debjeet Banerjee wrote:
> On Wed, Apr 22, 2026 at 01:46:33PM +0300, Sakari Ailus wrote:
> > It may well be but the rest of the driver doesn't appear to support DPCM
> > uncompression. Rather than trying to pretend it does, I'd instead just
> > remove any references to it.
>
> Thanks for the feedback Sakari.
>
> So if I understand correctly, the right fix here is to remove all the
> DPCM-related dead code: compressed_codes[], atomisp_subdev_uncompressed_code(),
> atomisp_subdev_is_compressed(), and atomisp_find_in_fmt_conv_compressed()
> declaration
>
> And in atomisp_csi2.c just keep the source pad copying the sink format as before,
> but drop the FIXME comment since we're explicitly acknowledging DPCM is not supported?
>
> Please let me know if I'm on the right track before I send v4 of this patch.
That's how it looks like to me, too.
--
Regards,
Sakari Ailus
next prev parent reply other threads:[~2026-04-22 11:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260420032701.33250-1-debjeetbanerjee48@gmail.com>
2026-04-20 4:34 ` [PATCH v2] staging: media: atomisp: csi2: Fix DPCM decompression for source pad format Debjeet Banerjee
2026-04-20 6:46 ` Andy Shevchenko
2026-04-20 7:42 ` Debjeet Banerjee
2026-04-21 8:22 ` [PATCH v3] " Debjeet Banerjee
2026-04-22 10:46 ` Sakari Ailus
2026-04-22 11:16 ` Debjeet Banerjee
2026-04-22 11:18 ` Sakari Ailus [this message]
2026-04-22 12:20 ` [PATCH v4 1/2] media: atomisp: csi2: Remove unimplemented DPCM decompression Debjeet Banerjee
2026-04-22 12:20 ` [PATCH v4 2/2] media: atomisp: Remove unused DPCM helper functions and declarations Debjeet Banerjee
2026-04-22 12:38 ` [PATCH v4 1/2] media: atomisp: csi2: Remove unimplemented DPCM decompression Sakari Ailus
2026-04-22 12:48 ` [PATCH v3] media: atomisp: csi2: Fix DPCM decompression for source pad format Debjeet Banerjee
2026-04-22 12:51 ` [PATCH v4 1/2] media: atomisp: csi2: Remove unimplemented DPCM decompression Debjeet Banerjee
2026-04-22 12:58 ` Sakari Ailus
2026-04-22 13:38 ` Debjeet Banerjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeiuhvqcT189lL5U@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=debjeetbanerjee48@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox