* [PATCH] staging: vme_user: fix missing blank line after declaration
@ 2026-04-18 11:58 Shyam Sunder Reddy Padira
2026-04-26 19:04 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Shyam Sunder Reddy Padira @ 2026-04-18 11:58 UTC (permalink / raw)
To: gregkh, linux-kernel, linux-staging; +Cc: akhilesh, Shyam Sunder Reddy Padira
Fix checkpatch.pl warning regarding:
-Missing a blank line after declaration
Add a blank line after variable declarations to comply
with kernel coding style and improve code readability.
Signed-off-by: Shyam Sunder Reddy Padira <shyamsunderreddypadira@gmail.com>
---
drivers/staging/vme_user/vme_tsi148.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/vme_user/vme_tsi148.h b/drivers/staging/vme_user/vme_tsi148.h
index f73ac92320bb..3102b94a0a86 100644
--- a/drivers/staging/vme_user/vme_tsi148.h
+++ b/drivers/staging/vme_user/vme_tsi148.h
@@ -34,6 +34,7 @@ struct tsi148_driver {
void __iomem *base; /* Base Address of device registers */
wait_queue_head_t dma_queue[2];
wait_queue_head_t iack_queue;
+
void (*lm_callback[4])(void *); /* Called in interrupt handler */
void *lm_data[4];
void *crcsr_kernel;
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] staging: vme_user: fix missing blank line after declaration
2026-04-18 11:58 [PATCH] staging: vme_user: fix missing blank line after declaration Shyam Sunder Reddy Padira
@ 2026-04-26 19:04 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2026-04-26 19:04 UTC (permalink / raw)
To: Shyam Sunder Reddy Padira; +Cc: linux-kernel, linux-staging, akhilesh
On Sat, Apr 18, 2026 at 05:28:57PM +0530, Shyam Sunder Reddy Padira wrote:
> Fix checkpatch.pl warning regarding:
> -Missing a blank line after declaration
>
> Add a blank line after variable declarations to comply
> with kernel coding style and improve code readability.
>
> Signed-off-by: Shyam Sunder Reddy Padira <shyamsunderreddypadira@gmail.com>
> ---
> drivers/staging/vme_user/vme_tsi148.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/vme_user/vme_tsi148.h b/drivers/staging/vme_user/vme_tsi148.h
> index f73ac92320bb..3102b94a0a86 100644
> --- a/drivers/staging/vme_user/vme_tsi148.h
> +++ b/drivers/staging/vme_user/vme_tsi148.h
> @@ -34,6 +34,7 @@ struct tsi148_driver {
> void __iomem *base; /* Base Address of device registers */
> wait_queue_head_t dma_queue[2];
> wait_queue_head_t iack_queue;
> +
> void (*lm_callback[4])(void *); /* Called in interrupt handler */
> void *lm_data[4];
> void *crcsr_kernel;
> --
> 2.43.0
>
>
This is a structure, not a function, checkpatch fooled you :(
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] staging: vme_user: fix missing blank line after declaration
@ 2026-03-14 22:05 Giacomo Di Clerico
2026-03-15 6:54 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Giacomo Di Clerico @ 2026-03-14 22:05 UTC (permalink / raw)
To: gregkh; +Cc: akhilesh, linux-staging, linux-kernel, Giacomo Di Clerico
Add a blank line between the last variable declaration and the
function pointer declaration in struct tsi148_driver, as required
by the kernel coding style.
Signed-off-by: Giacomo Di Clerico <giacomodiclerico@gmail.com>
---
drivers/staging/vme_user/vme_tsi148.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/vme_user/vme_tsi148.h b/drivers/staging/vme_user/vme_tsi148.h
index f73ac92320bb..3102b94a0a86 100644
--- a/drivers/staging/vme_user/vme_tsi148.h
+++ b/drivers/staging/vme_user/vme_tsi148.h
@@ -34,6 +34,7 @@ struct tsi148_driver {
void __iomem *base; /* Base Address of device registers */
wait_queue_head_t dma_queue[2];
wait_queue_head_t iack_queue;
+
void (*lm_callback[4])(void *); /* Called in interrupt handler */
void *lm_data[4];
void *crcsr_kernel;
--
2.53.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] staging: vme_user: fix missing blank line after declaration
2026-03-14 22:05 Giacomo Di Clerico
@ 2026-03-15 6:54 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2026-03-15 6:54 UTC (permalink / raw)
To: Giacomo Di Clerico; +Cc: akhilesh, linux-staging, linux-kernel
On Sat, Mar 14, 2026 at 11:05:03PM +0100, Giacomo Di Clerico wrote:
> Add a blank line between the last variable declaration and the
> function pointer declaration in struct tsi148_driver, as required
> by the kernel coding style.
>
> Signed-off-by: Giacomo Di Clerico <giacomodiclerico@gmail.com>
> ---
> drivers/staging/vme_user/vme_tsi148.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/vme_user/vme_tsi148.h b/drivers/staging/vme_user/vme_tsi148.h
> index f73ac92320bb..3102b94a0a86 100644
> --- a/drivers/staging/vme_user/vme_tsi148.h
> +++ b/drivers/staging/vme_user/vme_tsi148.h
> @@ -34,6 +34,7 @@ struct tsi148_driver {
> void __iomem *base; /* Base Address of device registers */
> wait_queue_head_t dma_queue[2];
> wait_queue_head_t iack_queue;
> +
> void (*lm_callback[4])(void *); /* Called in interrupt handler */
> void *lm_data[4];
> void *crcsr_kernel;
This is all a list of variables, no need for an extra line here.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-04-27 3:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-18 11:58 [PATCH] staging: vme_user: fix missing blank line after declaration Shyam Sunder Reddy Padira
2026-04-26 19:04 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2026-03-14 22:05 Giacomo Di Clerico
2026-03-15 6:54 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox