[PATCH] staging: rtl8723bs: remove redundant else block in sdio_halinit.c

[PATCH] staging: rtl8723bs: remove redundant else block in sdio_halinit.c

[Demir Özdemir]

Remove redundant else block after a return statement within if block in
rtl8723bs_hal_init(). Identified through checkpatch as a warning.

Signed-off-by: Demir Özdemir <demirozdemir@disroot.org>
---
 drivers/staging/rtl8723bs/hal/sdio_halinit.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index f2f73c65a636..809f07855bb8 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -654,11 +654,11 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
 		padapter->bFWReady = false;
 		pHalData->fw_ractrl = false;
 		return ret;
-	} else {
-		padapter->bFWReady = true;
-		pHalData->fw_ractrl = true;
 	}
 
+	padapter->bFWReady = true;
+	pHalData->fw_ractrl = true;
+
 	rtl8723b_InitializeFirmwareVars(padapter);
 
 /* 	SIC_Init(padapter); */
-- 
2.53.0

Re: [PATCH] staging: rtl8723bs: remove redundant else block in sdio_halinit.c

[Ethan Tidmore]

On Mon Apr 20, 2026 at 9:16 AM CDT, Demir Özdemir wrote:
> Remove redundant else block after a return statement within if block in
> rtl8723bs_hal_init(). Identified through checkpatch as a warning.
>
> Signed-off-by: Demir Özdemir <demirozdemir@disroot.org>
> ---

LGTM.

Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>

Thanks,

ET

Re: [PATCH] staging: rtl8723bs: remove redundant else block in sdio_halinit.c

[Luka Gejak]

On Mon Apr 20, 2026 at 4:16 PM CEST, Demir Özdemir wrote:
> Remove redundant else block after a return statement within if block in
> rtl8723bs_hal_init(). Identified through checkpatch as a warning.
>
> Signed-off-by: Demir Özdemir <demirozdemir@disroot.org>
> ---
>  drivers/staging/rtl8723bs/hal/sdio_halinit.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> index f2f73c65a636..809f07855bb8 100644
> --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> @@ -654,11 +654,11 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
>  		padapter->bFWReady = false;
>  		pHalData->fw_ractrl = false;
>  		return ret;
> -	} else {
> -		padapter->bFWReady = true;
> -		pHalData->fw_ractrl = true;
>  	}
>  
> +	padapter->bFWReady = true;
> +	pHalData->fw_ractrl = true;
> +
>  	rtl8723b_InitializeFirmwareVars(padapter);
>  
>  /* 	SIC_Init(padapter); */

LGTM.

Reviewed-by: Luka Gejak <luka.gejak@linux.dev>

Best regards,
Luka Gejak

Re: [PATCH] staging: rtl8723bs: remove redundant else block in sdio_halinit.c

[Greg KH]

On Mon, Apr 20, 2026 at 04:16:17PM +0200, Demir Özdemir wrote:
> Remove redundant else block after a return statement within if block in
> rtl8723bs_hal_init(). Identified through checkpatch as a warning.
> 
> Signed-off-by: Demir Özdemir <demirozdemir@disroot.org>
> Reviewed-by: Luka Gejak <luka.gejak@linux.dev>
> Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>
> ---
>  drivers/staging/rtl8723bs/hal/sdio_halinit.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> index f2f73c65a636..809f07855bb8 100644
> --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> @@ -654,11 +654,11 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
>  		padapter->bFWReady = false;
>  		pHalData->fw_ractrl = false;
>  		return ret;
> -	} else {
> -		padapter->bFWReady = true;
> -		pHalData->fw_ractrl = true;
>  	}
>  
> +	padapter->bFWReady = true;
> +	pHalData->fw_ractrl = true;
> +
>  	rtl8723b_InitializeFirmwareVars(padapter);
>  
>  /* 	SIC_Init(padapter); */
> -- 
> 2.53.0
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch did not apply to any known trees that Greg is in control
  of.  Possibly this is because you made it against Linus's tree, not
  the linux-next tree, which is where all of the development for the
  next version of the kernel is at.  Please refresh your patch against
  the linux-next tree, or even better yet, the development tree
  specified in the MAINTAINERS file for the subsystem you are submitting
  a patch for, and resend it.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot