[PATCH] staging: most: video: replace BUG_ON() in comp_exit

[PATCH] staging: most: video: replace BUG_ON() in comp_exit

[Ajith P V]

Replace BUG_ON() with WARN_ON() and pr_err inside comp_exit().

BUG_ON() is risky and not recommended to use in kernel.
It should replace with proper handlers such as WARN()-family
(see Documentation/process/deprecated.rst).

Signed-off-by: Ajith P V <ajithpv.linux@gmail.com>
---
 drivers/staging/most/video/video.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/most/video/video.c b/drivers/staging/most/video/video.c
index 04351f8ccccf..78cbf367c308 100644
--- a/drivers/staging/most/video/video.c
+++ b/drivers/staging/most/video/video.c
@@ -577,7 +577,8 @@ static void __exit comp_exit(void)
 
 	most_deregister_configfs_subsys(&comp);
 	most_deregister_component(&comp);
-	BUG_ON(!list_empty(&video_devices));
+	if (WARN_ON(!list_empty(&video_devices)))
+		pr_err("video_devices list not empty during module exit\n");
 }
 
 module_init(comp_init);
-- 
2.43.0

Re: [PATCH] staging: most: video: replace BUG_ON() in comp_exit

[Greg KH]

On Thu, Apr 16, 2026 at 04:33:34PM +0000, Ajith P V wrote:
> Replace BUG_ON() with WARN_ON() and pr_err inside comp_exit().
> 
> BUG_ON() is risky and not recommended to use in kernel.
> It should replace with proper handlers such as WARN()-family
> (see Documentation/process/deprecated.rst).
> 
> Signed-off-by: Ajith P V <ajithpv.linux@gmail.com>
> ---
>  drivers/staging/most/video/video.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/most/video/video.c b/drivers/staging/most/video/video.c
> index 04351f8ccccf..78cbf367c308 100644
> --- a/drivers/staging/most/video/video.c
> +++ b/drivers/staging/most/video/video.c
> @@ -577,7 +577,8 @@ static void __exit comp_exit(void)
>  
>  	most_deregister_configfs_subsys(&comp);
>  	most_deregister_component(&comp);
> -	BUG_ON(!list_empty(&video_devices));
> +	if (WARN_ON(!list_empty(&video_devices)))
> +		pr_err("video_devices list not empty during module exit\n");
>  }
>  
>  module_init(comp_init);
> -- 
> 2.43.0
> 

This was sent before you:
	https://lore.kernel.org/r/20260412222318.65045-1-grondon@gmail.com

which fixes it properly.  Also see all the other times replacing
BUG_ON() with WARN_ON() has been rejected by me in the past, so this
wouldn't be ok either.

thanks,

greg k-h