public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
* [PATCH] staging: greybus: bootrom: replace dev_info with dev_dbg for firmware name
@ 2026-04-28  0:24 kernelcoredev
  0 siblings, 0 replies; only message in thread
From: kernelcoredev @ 2026-04-28  0:24 UTC (permalink / raw)
  To: gregkh
  Cc: vireshk, johan, elder, greybus-dev, linux-staging, linux-kernel,
	kernelcoredev

The original dev_info call was intentionally temporary, with a FIXME
comment noting it should be downgraded to dev_dbg once modules with
valid VID/PID values were common. Project Ara was cancelled in 2016,
so that time has long passed.

Remove the FIXME comment and downgrade to dev_dbg as originally intended.

Tested via code inspection only, as Project Ara hardware is no longer
available.

Signed-off-by: Bentley Blacketer  <sonionwhat@gmail.com>
---
 drivers/staging/greybus/bootrom.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/greybus/bootrom.c b/drivers/staging/greybus/bootrom.c
index 83921d90c..757460c8b 100644
--- a/drivers/staging/greybus/bootrom.c
+++ b/drivers/staging/greybus/bootrom.c
@@ -168,12 +168,9 @@ static int find_firmware(struct gb_bootrom *bootrom, u8 stage)
 		 intf->ddbl1_manufacturer_id, intf->ddbl1_product_id,
 		 intf->vendor_id, intf->product_id);
 
-	// FIXME:
-	// Turn to dev_dbg later after everyone has valid bootloaders with good
-	// ids, but leave this as dev_info for now to make it easier to track
-	// down "empty" vid/pid modules.
-	dev_info(&connection->bundle->dev, "Firmware file '%s' requested\n",
-		 firmware_name);
+
+    dev_dbg(&connection->bundle->dev, "Firmware file '%s' requested\n",
+	    firmware_name);
 
 	rc = request_firmware(&bootrom->fw, firmware_name,
 			      &connection->bundle->dev);
-- 
2.54.0


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-04-28  0:24 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-28  0:24 [PATCH] staging: greybus: bootrom: replace dev_info with dev_dbg for firmware name kernelcoredev

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox