[PATCH] staging: rtl8723bs: remove unnecessary block comment

[PATCH] staging: rtl8723bs: remove unnecessary block comment

[Jennifer Guo]

Found a block comment formatting warning in odm_interface.h
via checkpatch.pl. As far as I can tell, this block comment is no
longer useful. Hence proposing to remove it.

Let me know if I missed anything!

Signed-off-by: Jennifer Guo <guojy.bj@gmail.com>
---
 drivers/staging/rtl8723bs/hal/odm_interface.h | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/odm_interface.h b/drivers/staging/rtl8723bs/hal/odm_interface.h
index 400473ca58ca..c3b13f5f37db 100644
--- a/drivers/staging/rtl8723bs/hal/odm_interface.h
+++ b/drivers/staging/rtl8723bs/hal/odm_interface.h
@@ -18,14 +18,6 @@
 #define _bit_all(_name)			BIT_##_name
 #define _bit_ic(_name, _ic)		BIT_##_name##_ic
 
-/*===================================
-
-#define ODM_REG_DIG_11N		0xC50
-#define ODM_REG_DIG_11AC	0xDDD
-
-ODM_REG(DIG)
-=====================================*/
-
 #define _reg_11N(_name)			ODM_REG_##_name##_11N
 #define _bit_11N(_name)			ODM_BIT_##_name##_11N
 
-- 
2.34.1

Re: [PATCH] staging: rtl8723bs: remove unnecessary block comment

[Nikolay Kulikov]

On Tue, May 05, 2026 at 11:54:31AM -0700, Jennifer Guo wrote:
> Found a block comment formatting warning in odm_interface.h
> via checkpatch.pl. As far as I can tell, this block comment is no
> longer useful. Hence proposing to remove it.

Typically, a commit message states "why" it should be accepted, not how
you arrived at it. This is described in detail in [1].


> Let me know if I missed anything!

Is this really needed in git log?


[1] https://kernelnewbies.org/PatchPhilosophy

Thanks,
Nikolay


> 
> Signed-off-by: Jennifer Guo <guojy.bj@gmail.com>
> ---
>  drivers/staging/rtl8723bs/hal/odm_interface.h | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/odm_interface.h b/drivers/staging/rtl8723bs/hal/odm_interface.h
> index 400473ca58ca..c3b13f5f37db 100644
> --- a/drivers/staging/rtl8723bs/hal/odm_interface.h
> +++ b/drivers/staging/rtl8723bs/hal/odm_interface.h
> @@ -18,14 +18,6 @@
>  #define _bit_all(_name)			BIT_##_name
>  #define _bit_ic(_name, _ic)		BIT_##_name##_ic
>  
> -/*===================================
> -
> -#define ODM_REG_DIG_11N		0xC50
> -#define ODM_REG_DIG_11AC	0xDDD
> -
> -ODM_REG(DIG)
> -=====================================*/
> -
>  #define _reg_11N(_name)			ODM_REG_##_name##_11N
>  #define _bit_11N(_name)			ODM_BIT_##_name##_11N
>  
> -- 
> 2.34.1
>