From: Maha Maryam Javaid <mahamaryamjavaid@gmail.com>
To: parthiban.veerasooran@microchip.com, christian.gromm@microchip.com
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Maha Maryam Javaid <mahamaryamjavaid@gmail.com>
Subject: [PATCH] staging: most: net: replace pr_err with netdev_err
Date: Fri, 8 May 2026 11:04:38 +0500 [thread overview]
Message-ID: <20260508060438.20156-1-mahamaryamjavaid@gmail.com> (raw)
Replace remaining pr_err() calls with netdev_err() where a net device
is available to provide better context in error messages.
Lines in skb_to_mep() are left as pr_err() since no net device
context is available there.
Signed-off-by: Maha Maryam Javaid <mahamaryamjavaid@gmail.com>
---
drivers/staging/most/net/net.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/most/net/net.c b/drivers/staging/most/net/net.c
index fc1dcff107ec..b481d053f826 100644
--- a/drivers/staging/most/net/net.c
+++ b/drivers/staging/most/net/net.c
@@ -339,13 +339,13 @@ static int comp_probe_channel(struct most_interface *iface, int channel_idx,
} else {
ch = ccfg->direction == MOST_CH_TX ? &nd->tx : &nd->rx;
if (ch->linked) {
- pr_err("direction is allocated\n");
+ netdev_err(nd->dev, "direction is allocated\n");
ret = -EINVAL;
goto unlock;
}
if (register_netdev(nd->dev)) {
- pr_err("register_netdev() failed\n");
+ netdev_err(nd->dev, "register_netdev() failed\n");
ret = -EINVAL;
goto unlock;
}
@@ -464,7 +464,7 @@ static int comp_rx_data(struct mbo *mbo)
if (!skb) {
dev->stats.rx_dropped++;
- pr_err_once("drop packet: no memory for skb\n");
+ netdev_err_once(dev, "drop packet: no memory for skb\n");
goto out;
}
--
2.34.1
next reply other threads:[~2026-05-08 6:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 6:04 Maha Maryam Javaid [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-04-29 3:29 [PATCH] staging: most: net: replace pr_err with netdev_err Maha Maryam Javaid
2026-05-04 14:17 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260508060438.20156-1-mahamaryamjavaid@gmail.com \
--to=mahamaryamjavaid@gmail.com \
--cc=christian.gromm@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=parthiban.veerasooran@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox