From: Maha Maryam Javaid <mahamaryamjavaid@gmail.com>
To: parthiban.veerasooran@microchip.com, christian.gromm@microchip.com
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Maha Maryam Javaid <mahamaryamjavaid@gmail.com>
Subject: [PATCH] staging: most: net: replace pr_err with netdev_err
Date: Tue, 28 Apr 2026 23:29:34 -0400 [thread overview]
Message-ID: <20260429032934.10683-1-mahamaryamjavaid@gmail.com> (raw)
Replace pr_err() calls with netdev_err() in skb_to_mamac() to provide
better context by including the net device name in the error messages.
Signed-off-by: Maha Maryam Javaid <mahamaryamjavaid@gmail.com>
---
drivers/staging/most/net/net.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/most/net/net.c b/drivers/staging/most/net/net.c
index fffdb60cd230..fc1dcff107ec 100644
--- a/drivers/staging/most/net/net.c
+++ b/drivers/staging/most/net/net.c
@@ -81,18 +81,18 @@ static int skb_to_mamac(const struct sk_buff *skb, struct mbo *mbo)
unsigned int mdp_len = payload_len + MDP_HDR_LEN;
if (mdp_len < skb->len) {
- pr_err("drop: too large packet! (%u)\n", skb->len);
+ netdev_err(skb->dev, "drop: too large packet! (%u)\n", skb->len);
return -EINVAL;
}
if (mbo->buffer_length < mdp_len) {
- pr_err("drop: too small buffer! (%d for %d)\n",
- mbo->buffer_length, mdp_len);
+ netdev_err(skb->dev, "drop: too small buffer! (%d for %d)\n",
+ mbo->buffer_length, mdp_len);
return -EINVAL;
}
if (skb->len < ETH_HLEN) {
- pr_err("drop: too small packet! (%d)\n", skb->len);
+ netdev_err(skb->dev, "drop: too small packet! (%d)\n", skb->len);
return -EINVAL;
}
--
2.34.1
next reply other threads:[~2026-04-29 3:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 3:29 Maha Maryam Javaid [this message]
2026-05-04 14:17 ` [PATCH] staging: most: net: replace pr_err with netdev_err Greg KH
-- strict thread matches above, loose matches on Subject: below --
2026-05-08 6:04 Maha Maryam Javaid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260429032934.10683-1-mahamaryamjavaid@gmail.com \
--to=mahamaryamjavaid@gmail.com \
--cc=christian.gromm@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=parthiban.veerasooran@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox