[PATCH] staging: most: net: replace pr_err with netdev_err

[PATCH] staging: most: net: replace pr_err with netdev_err

[Maha Maryam Javaid]

Replace pr_err() calls with netdev_err() in skb_to_mamac() to provide
better context by including the net device name in the error messages.

Signed-off-by: Maha Maryam Javaid <mahamaryamjavaid@gmail.com>
---
 drivers/staging/most/net/net.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/most/net/net.c b/drivers/staging/most/net/net.c
index fffdb60cd230..fc1dcff107ec 100644
--- a/drivers/staging/most/net/net.c
+++ b/drivers/staging/most/net/net.c
@@ -81,18 +81,18 @@ static int skb_to_mamac(const struct sk_buff *skb, struct mbo *mbo)
 	unsigned int mdp_len = payload_len + MDP_HDR_LEN;
 
 	if (mdp_len < skb->len) {
-		pr_err("drop: too large packet! (%u)\n", skb->len);
+		netdev_err(skb->dev, "drop: too large packet! (%u)\n", skb->len);
 		return -EINVAL;
 	}
 
 	if (mbo->buffer_length < mdp_len) {
-		pr_err("drop: too small buffer! (%d for %d)\n",
-		       mbo->buffer_length, mdp_len);
+		netdev_err(skb->dev, "drop: too small buffer! (%d for %d)\n",
+			   mbo->buffer_length, mdp_len);
 		return -EINVAL;
 	}
 
 	if (skb->len < ETH_HLEN) {
-		pr_err("drop: too small packet! (%d)\n", skb->len);
+		netdev_err(skb->dev, "drop: too small packet! (%d)\n", skb->len);
 		return -EINVAL;
 	}
 
-- 
2.34.1

Re: [PATCH] staging: most: net: replace pr_err with netdev_err

[Greg KH]

On Tue, Apr 28, 2026 at 11:29:34PM -0400, Maha Maryam Javaid wrote:
> Replace pr_err() calls with netdev_err() in skb_to_mamac() to provide
> better context by including the net device name in the error messages.
> 
> Signed-off-by: Maha Maryam Javaid <mahamaryamjavaid@gmail.com>
> ---
>  drivers/staging/most/net/net.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/most/net/net.c b/drivers/staging/most/net/net.c
> index fffdb60cd230..fc1dcff107ec 100644
> --- a/drivers/staging/most/net/net.c
> +++ b/drivers/staging/most/net/net.c
> @@ -81,18 +81,18 @@ static int skb_to_mamac(const struct sk_buff *skb, struct mbo *mbo)
>  	unsigned int mdp_len = payload_len + MDP_HDR_LEN;
>  
>  	if (mdp_len < skb->len) {
> -		pr_err("drop: too large packet! (%u)\n", skb->len);
> +		netdev_err(skb->dev, "drop: too large packet! (%u)\n", skb->len);
>  		return -EINVAL;
>  	}
>  
>  	if (mbo->buffer_length < mdp_len) {
> -		pr_err("drop: too small buffer! (%d for %d)\n",
> -		       mbo->buffer_length, mdp_len);
> +		netdev_err(skb->dev, "drop: too small buffer! (%d for %d)\n",
> +			   mbo->buffer_length, mdp_len);
>  		return -EINVAL;
>  	}
>  
>  	if (skb->len < ETH_HLEN) {
> -		pr_err("drop: too small packet! (%d)\n", skb->len);
> +		netdev_err(skb->dev, "drop: too small packet! (%d)\n", skb->len);
>  		return -EINVAL;
>  	}
>  
> -- 
> 2.34.1
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch did not apply to any known trees that Greg is in control
  of.  Possibly this is because you made it against Linus's tree, not
  the linux-next tree, which is where all of the development for the
  next version of the kernel is at.  Please refresh your patch against
  the linux-next tree, or even better yet, the development tree
  specified in the MAINTAINERS file for the subsystem you are submitting
  a patch for, and resend it.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

[PATCH] staging: most: net: replace pr_err with netdev_err

[Maha Maryam Javaid]

Replace remaining pr_err() calls with netdev_err() where a net device
is available to provide better context in error messages.

Lines in skb_to_mep() are left as pr_err() since no net device
context is available there.

Signed-off-by: Maha Maryam Javaid <mahamaryamjavaid@gmail.com>
---
 drivers/staging/most/net/net.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/most/net/net.c b/drivers/staging/most/net/net.c
index fc1dcff107ec..b481d053f826 100644
--- a/drivers/staging/most/net/net.c
+++ b/drivers/staging/most/net/net.c
@@ -339,13 +339,13 @@ static int comp_probe_channel(struct most_interface *iface, int channel_idx,
 	} else {
 		ch = ccfg->direction == MOST_CH_TX ? &nd->tx : &nd->rx;
 		if (ch->linked) {
-			pr_err("direction is allocated\n");
+			netdev_err(nd->dev, "direction is allocated\n");
 			ret = -EINVAL;
 			goto unlock;
 		}
 
 		if (register_netdev(nd->dev)) {
-			pr_err("register_netdev() failed\n");
+			netdev_err(nd->dev, "register_netdev() failed\n");
 			ret = -EINVAL;
 			goto unlock;
 		}
@@ -464,7 +464,7 @@ static int comp_rx_data(struct mbo *mbo)
 
 	if (!skb) {
 		dev->stats.rx_dropped++;
-		pr_err_once("drop packet: no memory for skb\n");
+		netdev_err_once(dev, "drop packet: no memory for skb\n");
 		goto out;
 	}
 
-- 
2.34.1