Linux kernel staging patches
 help / color / mirror / Atom feed
* [PATCH v4] staging: media: atomisp: remove stale "Generated code" comments
       [not found] <20260512-atomisp-remove-generated-comment-v4-1-4095ab7e2c14.ref@yahoo.pl>
@ 2026-05-12 19:35 ` Tomasz Unger
  2026-05-13 10:47   ` M.samet Duman
  0 siblings, 1 reply; 2+ messages in thread
From: Tomasz Unger @ 2026-05-12 19:35 UTC (permalink / raw)
  To: Andy Shevchenko, Hans de Goede, Mauro Carvalho Chehab,
	Sakari Ailus, Greg Kroah-Hartman
  Cc: linux-media, linux-kernel, linux-staging, Andy Shevchenko,
	Tomasz Unger

Remove the "Generated code: do not edit or commmit." comments and
the resulting double blank lines from five files. This code is coupled
with legacy firmware and will never be re-generated, so the comment
is misleading and should be dropped entirely rather than having its
typo fixed.

Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
---
Changes in v4:
- Fix Suggested-by tag attribution (Andy Shevchenko, not Dan Carpenter)
- Add Reviewed-by from Andy Shevchenko
- Link to v3: https://patch.msgid.link/20260512-atomisp-remove-generated-comment-v3-1-97930e4e1ca8@yahoo.pl
---
 drivers/staging/media/atomisp/pci/ia_css_isp_configs.c | 2 --
 drivers/staging/media/atomisp/pci/ia_css_isp_params.c  | 1 -
 drivers/staging/media/atomisp/pci/ia_css_isp_params.h  | 2 --
 drivers/staging/media/atomisp/pci/ia_css_isp_states.c  | 1 -
 drivers/staging/media/atomisp/pci/ia_css_isp_states.h  | 1 -
 5 files changed, 7 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/ia_css_isp_configs.c b/drivers/staging/media/atomisp/pci/ia_css_isp_configs.c
index 38c9c62366d6..c33d963d9069 100644
--- a/drivers/staging/media/atomisp/pci/ia_css_isp_configs.c
+++ b/drivers/staging/media/atomisp/pci/ia_css_isp_configs.c
@@ -4,8 +4,6 @@
  * Copyright (c) 2015, Intel Corporation.
  */
 
-/* Generated code: do not edit or commmit. */
-
 #define IA_CSS_INCLUDE_CONFIGURATIONS
 #include "ia_css_pipeline.h"
 #include "ia_css_isp_configs.h"
diff --git a/drivers/staging/media/atomisp/pci/ia_css_isp_params.c b/drivers/staging/media/atomisp/pci/ia_css_isp_params.c
index 1cd3322b0da0..96af15f62060 100644
--- a/drivers/staging/media/atomisp/pci/ia_css_isp_params.c
+++ b/drivers/staging/media/atomisp/pci/ia_css_isp_params.c
@@ -48,7 +48,6 @@
 #include "isp/kernels/eed1_8/ia_css_eed1_8.host.h"
 #include "isp/kernels/bnlm/ia_css_bnlm.host.h"
 #include "isp/kernels/conversion/conversion_1.0/ia_css_conversion.host.h"
-/* Generated code: do not edit or commmit. */
 
 #include "ia_css_pipeline.h"
 #include "ia_css_isp_params.h"
diff --git a/drivers/staging/media/atomisp/pci/ia_css_isp_params.h b/drivers/staging/media/atomisp/pci/ia_css_isp_params.h
index a542f8979905..40ef6e35c30d 100644
--- a/drivers/staging/media/atomisp/pci/ia_css_isp_params.h
+++ b/drivers/staging/media/atomisp/pci/ia_css_isp_params.h
@@ -4,8 +4,6 @@
  * Copyright (c) 2015, Intel Corporation.
  */
 
-/* Generated code: do not edit or commmit. */
-
 #ifndef _IA_CSS_ISP_PARAM_H
 #define _IA_CSS_ISP_PARAM_H
 
diff --git a/drivers/staging/media/atomisp/pci/ia_css_isp_states.c b/drivers/staging/media/atomisp/pci/ia_css_isp_states.c
index af1765040464..1ea71477e774 100644
--- a/drivers/staging/media/atomisp/pci/ia_css_isp_states.c
+++ b/drivers/staging/media/atomisp/pci/ia_css_isp_states.c
@@ -3,7 +3,6 @@
  * Support for Intel Camera Imaging ISP subsystem.
  * Copyright (c) 2015, Intel Corporation.
  */
-/* Generated code: do not edit or commmit. */
 
 #include "ia_css_pipeline.h"
 #include "ia_css_isp_states.h"
diff --git a/drivers/staging/media/atomisp/pci/ia_css_isp_states.h b/drivers/staging/media/atomisp/pci/ia_css_isp_states.h
index d637ea1d13f6..5bd1d4ae1fe4 100644
--- a/drivers/staging/media/atomisp/pci/ia_css_isp_states.h
+++ b/drivers/staging/media/atomisp/pci/ia_css_isp_states.h
@@ -15,7 +15,6 @@
 #include "isp/kernels/ynr/ynr_1.0/ia_css_ynr.host.h"
 #include "isp/kernels/dpc2/ia_css_dpc2.host.h"
 #include "isp/kernels/eed1_8/ia_css_eed1_8.host.h"
-/* Generated code: do not edit or commmit. */
 
 #ifndef _IA_CSS_ISP_STATE_H
 #define _IA_CSS_ISP_STATE_H

---
base-commit: 6abf0b2df0b1c2205a4c0591425e6461afa62edb
change-id: 20260512-atomisp-remove-generated-comment-0f6912dc8cb8

Best regards,
--  
Tomasz Unger <tomasz.unger@yahoo.pl>


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v4] staging: media: atomisp: remove stale "Generated code" comments
  2026-05-12 19:35 ` [PATCH v4] staging: media: atomisp: remove stale "Generated code" comments Tomasz Unger
@ 2026-05-13 10:47   ` M.samet Duman
  0 siblings, 0 replies; 2+ messages in thread
From: M.samet Duman @ 2026-05-13 10:47 UTC (permalink / raw)
  To: Tomasz Unger
  Cc: Andy Shevchenko, Hans de Goede, Mauro Carvalho Chehab,
	Sakari Ailus, Greg Kroah-Hartman, linux-media, linux-kernel,
	linux-staging, Andy Shevchenko, Tomasz Unger

It's interesting that there's an extra 'm', and I think it must be left over from the porting application they used when they first tried to include this driver.

--
Samet

> 2026. 5. 12. 오후 10:39, Tomasz Unger <tomasz.unger@yahoo.pl> 작성:
> 
> generated

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-05-13 10:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20260512-atomisp-remove-generated-comment-v4-1-4095ab7e2c14.ref@yahoo.pl>
2026-05-12 19:35 ` [PATCH v4] staging: media: atomisp: remove stale "Generated code" comments Tomasz Unger
2026-05-13 10:47   ` M.samet Duman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox