* [PATCH v8] staging: rtl8723bs: remove unnecessary braces in rtw_mlme.c
@ 2026-05-12 12:11 Ashwin Gundarapu
2026-05-12 12:16 ` gregkh
0 siblings, 1 reply; 2+ messages in thread
From: Ashwin Gundarapu @ 2026-05-12 12:11 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, linux-staging
From c981cdc1149e5ae7e5163f80be1631fc11c4b14d Mon Sep 17 00:00:00 2001
From: Ashwin Gundarapu <linuxuser509@zohomail.in>
Date: Tue, 12 May 2026 17:38:31 +0530
Subject: [PATCH] staging: rtl8723bs: remove unnecessary braces in rtw_mlme.c
Remove braces around single statement blocks.
Found by checkpatch.pl --strict
Signed-off-by: Ashwin Gundarapu <linuxuser509@zohomail.in>
---
v8: Fixed double blank lines. One blank line only between statements.
v7: Added version changelog below the --- line as requested by Greg KH.
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index c14b8dbd478b..3d88a3a185d5 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -483,10 +483,10 @@ void rtw_update_scanned_network(struct adapter *adapter, struct wlan_bssid_ex *t
break;
}
+
if (rtw_roam_flags(adapter))
/* TODO: don't select network in the same ess as oldest if it's new enough*/
-
if (!oldest || time_after(oldest->last_scanned, pnetwork->last_scanned))
oldest = pnetwork;
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v8] staging: rtl8723bs: remove unnecessary braces in rtw_mlme.c
2026-05-12 12:11 [PATCH v8] staging: rtl8723bs: remove unnecessary braces in rtw_mlme.c Ashwin Gundarapu
@ 2026-05-12 12:16 ` gregkh
0 siblings, 0 replies; 2+ messages in thread
From: gregkh @ 2026-05-12 12:16 UTC (permalink / raw)
To: Ashwin Gundarapu; +Cc: linux-kernel, linux-staging
On Tue, May 12, 2026 at 05:41:42PM +0530, Ashwin Gundarapu wrote:
>
> >From c981cdc1149e5ae7e5163f80be1631fc11c4b14d Mon Sep 17 00:00:00 2001
> From: Ashwin Gundarapu <linuxuser509@zohomail.in>
> Date: Tue, 12 May 2026 17:38:31 +0530
> Subject: [PATCH] staging: rtl8723bs: remove unnecessary braces in rtw_mlme.c
Why is this in the body?
>
> Remove braces around single statement blocks.
>
> Found by checkpatch.pl --strict
>
> Signed-off-by: Ashwin Gundarapu <linuxuser509@zohomail.in>
> ---
> v8: Fixed double blank lines. One blank line only between statements.
> v7: Added version changelog below the --- line as requested by Greg KH.
> ---
What about v1 - v6?
> drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> index c14b8dbd478b..3d88a3a185d5 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> @@ -483,10 +483,10 @@ void rtw_update_scanned_network(struct adapter *adapter, struct wlan_bssid_ex *t
> break;
> }
>
> +
> if (rtw_roam_flags(adapter))
> /* TODO: don't select network in the same ess as oldest if it's new enough*/
>
> -
This is not what you describe above at all :(
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-12 12:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-12 12:11 [PATCH v8] staging: rtl8723bs: remove unnecessary braces in rtw_mlme.c Ashwin Gundarapu
2026-05-12 12:16 ` gregkh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox