From: Nikolay Kulikov <nikolayof23@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Dan Carpenter <error27@gmail.com>,
linux-staging@lists.linux.dev,
Nikolay Kulikov <nikolayof23@gmail.com>
Subject: [PATCH v2 2/4] staging: rtl8723bs: remove empty InitSysInterrupt8723BSdio()
Date: Tue, 12 May 2026 15:55:32 +0300 [thread overview]
Message-ID: <20260512125703.6878-3-nikolayof23@gmail.com> (raw)
In-Reply-To: <20260512125703.6878-1-nikolayof23@gmail.com>
This function does not do any useful work to initialize interrupt, so
remove it co clean up dead code.
Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
---
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 5 -----
drivers/staging/rtl8723bs/hal/sdio_ops.c | 13 -------------
drivers/staging/rtl8723bs/include/sdio_ops.h | 1 -
3 files changed, 19 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index 1e0498268aee..eecfc593e2dd 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -532,11 +532,6 @@ static void _InitInterrupt(struct adapter *padapter)
/* Initialize and enable SDIO Host Interrupt. */
/* */
InitInterrupt8723BSdio(padapter);
-
- /* */
- /* Initialize system Host Interrupt. */
- /* */
- InitSysInterrupt8723BSdio(padapter);
}
static void _InitRFType(struct adapter *padapter)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c
index 0c0c243c46eb..f7f6e273c868 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_ops.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c
@@ -581,19 +581,6 @@ void InitInterrupt8723BSdio(struct adapter *adapter)
0);
}
-/* */
-/* Description: */
-/* Initialize System Host Interrupt Mask configuration variables for future use. */
-/* */
-/* Created by Roger, 2011.08.03. */
-/* */
-void InitSysInterrupt8723BSdio(struct adapter *adapter)
-{
- struct hal_com_data *haldata;
-
- haldata = GET_HAL_DATA(adapter);
-}
-
/*
* Enable SDIO Host Interrupt Mask configuration on SDIO local domain.
*
diff --git a/drivers/staging/rtl8723bs/include/sdio_ops.h b/drivers/staging/rtl8723bs/include/sdio_ops.h
index 13f13076bc16..252b0e1646e5 100644
--- a/drivers/staging/rtl8723bs/include/sdio_ops.h
+++ b/drivers/staging/rtl8723bs/include/sdio_ops.h
@@ -26,7 +26,6 @@ extern void sd_int_hdl(struct adapter *padapter);
extern u8 CheckIPSStatus(struct adapter *padapter);
extern void InitInterrupt8723BSdio(struct adapter *padapter);
-extern void InitSysInterrupt8723BSdio(struct adapter *padapter);
void rtw_sdio_enable_interrupt(struct adapter *padapter);
void rtw_sdio_disable_interrupt(struct adapter *padapter);
extern u8 HalQueryTxBufferStatus8723BSdio(struct adapter *padapter);
--
2.54.0
next prev parent reply other threads:[~2026-05-12 12:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 12:55 [PATCH v2 0/4] staging: rtl8723bs: remove unused sys interrupt Nikolay Kulikov
2026-05-12 12:55 ` [PATCH v2 1/4] staging: rtl8723bs: remove unused SysIntrMask from struct hal_com_data Nikolay Kulikov
2026-05-12 12:55 ` Nikolay Kulikov [this message]
2026-05-12 12:55 ` [PATCH v2 3/4] staging: rtl8723bs: remove overwriting of current IMR settings Nikolay Kulikov
2026-05-12 12:55 ` [PATCH v2 4/4] staging: rtl8723bs: remove unused SysIntrStatus from struct hal_com_data Nikolay Kulikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260512125703.6878-3-nikolayof23@gmail.com \
--to=nikolayof23@gmail.com \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox