From: Nikolay Kulikov <nikolayof23@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Dan Carpenter <error27@gmail.com>,
linux-staging@lists.linux.dev,
Nikolay Kulikov <nikolayof23@gmail.com>
Subject: [PATCH v2 3/4] staging: rtl8723bs: remove overwriting of current IMR settings
Date: Tue, 12 May 2026 15:55:33 +0300 [thread overview]
Message-ID: <20260512125703.6878-4-nikolayof23@gmail.com> (raw)
In-Reply-To: <20260512125703.6878-1-nikolayof23@gmail.com>
Originally, this code use to
Step 1: Read a value from register
Step 2: Add some bits to the value
Step 3: Write the result back to the same register
The problem was that the bits in Step 2 were always zero and didn't
change the value, so I have removed that code. Now this function
just reads a value and writes the same value back. It is unnecessary
and can be removed.
Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
---
Changes in v2:
- Make the commit message clearer, as suggested by Dan Carpenter
drivers/staging/rtl8723bs/hal/sdio_ops.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c
index f7f6e273c868..91580f6ba52e 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_ops.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c
@@ -592,17 +592,12 @@ void rtw_sdio_enable_interrupt(struct adapter *adapter)
{
struct hal_com_data *haldata;
__le32 himr;
- u32 tmp;
haldata = GET_HAL_DATA(adapter);
himr = cpu_to_le32(haldata->sdio_himr);
sdio_local_write(adapter, SDIO_REG_HIMR, 4, (u8 *)&himr);
- /* Update current system IMR settings */
- tmp = rtw_read32(adapter, REG_HSIMR);
- rtw_write32(adapter, REG_HSIMR, tmp);
-
/* */
/* <Roger_Notes> There are some C2H CMDs have been sent before system interrupt is enabled, e.g., C2H, CPWM. */
/* So we need to clear all C2H events that FW has notified, otherwise FW won't schedule any commands anymore. */
--
2.54.0
next prev parent reply other threads:[~2026-05-12 12:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 12:55 [PATCH v2 0/4] staging: rtl8723bs: remove unused sys interrupt Nikolay Kulikov
2026-05-12 12:55 ` [PATCH v2 1/4] staging: rtl8723bs: remove unused SysIntrMask from struct hal_com_data Nikolay Kulikov
2026-05-12 12:55 ` [PATCH v2 2/4] staging: rtl8723bs: remove empty InitSysInterrupt8723BSdio() Nikolay Kulikov
2026-05-12 12:55 ` Nikolay Kulikov [this message]
2026-05-12 12:55 ` [PATCH v2 4/4] staging: rtl8723bs: remove unused SysIntrStatus from struct hal_com_data Nikolay Kulikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260512125703.6878-4-nikolayof23@gmail.com \
--to=nikolayof23@gmail.com \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox