Linux kernel staging patches
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Moksh Panicker <mokshpanicker.7@gmail.com>
Cc: linux-staging@lists.linux.dev
Subject: Re: [PATCH 4/4] staging: rtl8723bs: fix missing brace in rtw_efuse_read_1_byte
Date: Sat, 16 May 2026 18:02:50 +0200	[thread overview]
Message-ID: <2026051608-snowcap-shield-56f3@gregkh> (raw)
In-Reply-To: <20260516155025.230865-5-mokshpanicker.7@gmail.com>

On Sat, May 16, 2026 at 03:50:25PM +0000, Moksh Panicker wrote:
> ---
>  drivers/staging/rtl8723bs/core/rtw_efuse.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> index ef0cec40d388..a9bbfe2d6fb2 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> @@ -75,8 +75,8 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
>  		return rtw_read8(Adapter, EFUSE_CTRL);
>  	} else {
>  		return 0xFF;
> -
> -} /* rtw_efuse_read_1_byte */
> +	}
> +}/* rtw_efuse_read_1_byte */
>  
>  /*  11/16/2008 MH Read one byte from real Efuse. */
>  u8 rtw_efuse_one_byte_read(struct adapter *padapter, u16 addr, u8 *data)
> -- 
> 2.34.1
> 
> 

This really does not look correct at all...

Take some time, work on this again, and resend the series to yourself to
see what they look like and if they make any sense or not.

(hint, checkpatch should have complained about this one...)

thanks,

greg k-h

  reply	other threads:[~2026-05-16 16:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-16 15:50 [PATCH v4 0/4] staging: rtl8723bs: fix efuse formatting and brace handling Moksh Panicker
2026-05-16 15:50 ` [PATCH 1/4] staging: rtl8723bs: reformat rtw_efuse_read_1_byte() signature Moksh Panicker
2026-05-16 15:50 ` [PATCH 2/4] staging: rtl8723bs: add braces to else clause in rtw_efuse.c Moksh Panicker
2026-05-16 15:50 ` [PATCH 3/4] staging: rtl8723bs: reformat rtw_efuse_one_byte_read() signature Moksh Panicker
2026-05-16 15:50 ` [PATCH 4/4] staging: rtl8723bs: fix missing brace in rtw_efuse_read_1_byte Moksh Panicker
2026-05-16 16:02   ` Greg KH [this message]
2026-05-16 16:58     ` Moksh Panicker
2026-05-16 17:04       ` Moksh Panicker
2026-05-17 14:41         ` Moksh Panicker
2026-05-18  4:59   ` Dan Carpenter
  -- strict thread matches above, loose matches on Subject: below --
2026-05-17 14:37 [PATCH v4 0/4] staging: rtl8723bs: fix efuse formatting and brace handling Moksh Panicker
2026-05-17 14:37 ` [PATCH 4/4] staging: rtl8723bs: fix missing brace in rtw_efuse_read_1_byte Moksh Panicker
2026-05-17 14:56   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026051608-snowcap-shield-56f3@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mokshpanicker.7@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox