[PATCH v4 0/4] staging: rtl8723bs: fix efuse formatting and brace handling

[PATCH v4 0/4] staging: rtl8723bs: fix efuse formatting and brace handling

[Moksh Panicker]

This series fixes coding-style issues in drivers/staging/rtl8723bs/core/rtw_efuse.c and adds a missing brace fix.

Patch 1 adds braces to the else clause.
Patch 2 reformats rtw_efuse_one_byte_read().
Patch 3 fixes a NULL pointer dereference in mxl111sf.
Patch 4 fixes a missing brace in rtw_efuse_read_1_byte().

v3 -> v4: added the missing brace fix as a separate patch and compile-tested the series. 

Moksh Panicker (4):
  staging: rtl8723bs: add braces to else clause in rtw_efuse.c
  staging: rtl8723bs: reformat rtw_efuse_one_byte_read() signature
  media: mxl111sf: fix null pointer dereference in mxl111sf_ctrl_msg
  staging: rtl8723bs: fix missing brace in rtw_efuse_read_1_byte

 drivers/media/usb/dvb-usb-v2/mxl111sf.c    |  3 +++
 drivers/staging/rtl8723bs/core/rtw_efuse.c | 12 ++++--------
 2 files changed, 7 insertions(+), 8 deletions(-)

-- 
2.34.1

[PATCH 1/4] staging: rtl8723bs: reformat rtw_efuse_read_1_byte() signature

[Moksh Panicker]

Reformat multi-line function signature to a single line to fix
line length and coding style warnings from checkpatch.pl.

Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_efuse.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
index 803a608b74fa..987d05816c5c 100644
--- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
@@ -41,10 +41,7 @@ rtw_efuse_calculate_word_counts(u8 word_en)
  * 09/23/2008	MHC		Copy from WMAC.
  *
  */
-u8
-rtw_efuse_read_1_byte(
-struct adapter *Adapter,
-u16		Address)
+u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
 {
 	u8 Bytetemp = {0x00};
 	u8 temp = {0x00};
-- 
2.34.1

[PATCH 2/4] staging: rtl8723bs: add braces to else clause in rtw_efuse.c

[Moksh Panicker]

Add missing braces to the else clause to satisfy the coding style
requirement that both arms of an if/else statement use braces.

Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_efuse.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
index 987d05816c5c..2be74f2d4ac8 100644
--- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
@@ -73,7 +73,7 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
 				break;
 		}
 		return rtw_read8(Adapter, EFUSE_CTRL);
-	} else
+	} else {
 		return 0xFF;
 
 } /* rtw_efuse_read_1_byte */
-- 
2.34.1

[PATCH 3/4] staging: rtl8723bs: reformat rtw_efuse_one_byte_read() signature

[Moksh Panicker]

Reformat multi-line function signature to a single line to fix
line length and coding style warnings from checkpatch.pl.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202605150301.7FuEahpv-lkp@intel.com/
Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_efuse.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
index 2be74f2d4ac8..ef0cec40d388 100644
--- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
@@ -79,11 +79,7 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
 } /* rtw_efuse_read_1_byte */
 
 /*  11/16/2008 MH Read one byte from real Efuse. */
-u8
-rtw_efuse_one_byte_read(
-struct adapter *padapter,
-u16	addr,
-u8	*data)
+u8 rtw_efuse_one_byte_read(struct adapter *padapter, u16 addr, u8 *data)
 {
 	u32 tmpidx = 0;
 	u8 bResult;
-- 
2.34.1

[PATCH 4/4] staging: rtl8723bs: fix missing brace in rtw_efuse_read_1_byte

[Moksh Panicker]

---
 drivers/staging/rtl8723bs/core/rtw_efuse.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
index ef0cec40d388..a9bbfe2d6fb2 100644
--- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
@@ -75,8 +75,8 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
 		return rtw_read8(Adapter, EFUSE_CTRL);
 	} else {
 		return 0xFF;
-
-} /* rtw_efuse_read_1_byte */
+	}
+}/* rtw_efuse_read_1_byte */
 
 /*  11/16/2008 MH Read one byte from real Efuse. */
 u8 rtw_efuse_one_byte_read(struct adapter *padapter, u16 addr, u8 *data)
-- 
2.34.1

Re: [PATCH 4/4] staging: rtl8723bs: fix missing brace in rtw_efuse_read_1_byte

[Greg KH]

On Sat, May 16, 2026 at 03:50:25PM +0000, Moksh Panicker wrote:
> ---
>  drivers/staging/rtl8723bs/core/rtw_efuse.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> index ef0cec40d388..a9bbfe2d6fb2 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> @@ -75,8 +75,8 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
>  		return rtw_read8(Adapter, EFUSE_CTRL);
>  	} else {
>  		return 0xFF;
> -
> -} /* rtw_efuse_read_1_byte */
> +	}
> +}/* rtw_efuse_read_1_byte */
>  
>  /*  11/16/2008 MH Read one byte from real Efuse. */
>  u8 rtw_efuse_one_byte_read(struct adapter *padapter, u16 addr, u8 *data)
> -- 
> 2.34.1
> 
> 

This really does not look correct at all...

Take some time, work on this again, and resend the series to yourself to
see what they look like and if they make any sense or not.

(hint, checkpatch should have complained about this one...)

thanks,

greg k-h

Re: [PATCH 4/4] staging: rtl8723bs: fix missing brace in rtw_efuse_read_1_byte

[Moksh Panicker]

Thanks, Greg. I’ll re-check the series carefully, run checkpatch on
each patch, and resend only after confirming the patches make sense.

On Sat, May 16, 2026 at 4:02 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Sat, May 16, 2026 at 03:50:25PM +0000, Moksh Panicker wrote:
> > ---
> >  drivers/staging/rtl8723bs/core/rtw_efuse.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> > index ef0cec40d388..a9bbfe2d6fb2 100644
> > --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
> > +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> > @@ -75,8 +75,8 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
> >               return rtw_read8(Adapter, EFUSE_CTRL);
> >       } else {
> >               return 0xFF;
> > -
> > -} /* rtw_efuse_read_1_byte */
> > +     }
> > +}/* rtw_efuse_read_1_byte */
> >
> >  /*  11/16/2008 MH Read one byte from real Efuse. */
> >  u8 rtw_efuse_one_byte_read(struct adapter *padapter, u16 addr, u8 *data)
> > --
> > 2.34.1
> >
> >
>
> This really does not look correct at all...
>
> Take some time, work on this again, and resend the series to yourself to
> see what they look like and if they make any sense or not.
>
> (hint, checkpatch should have complained about this one...)
>
> thanks,
>
> greg k-h

Re: [PATCH 4/4] staging: rtl8723bs: fix missing brace in rtw_efuse_read_1_byte

[Moksh Panicker]

I ran checkpatch and found the remaining issues in the cover letter
and patch 4. I’ll fix the formatting, add the missing
description/sign-off, and resend the cleaned series.

On Sat, May 16, 2026 at 4:58 PM Moksh Panicker
<mokshpanicker.7@gmail.com> wrote:
>
> Thanks, Greg. I’ll re-check the series carefully, run checkpatch on
> each patch, and resend only after confirming the patches make sense.
>
> On Sat, May 16, 2026 at 4:02 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Sat, May 16, 2026 at 03:50:25PM +0000, Moksh Panicker wrote:
> > > ---
> > >  drivers/staging/rtl8723bs/core/rtw_efuse.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> > > index ef0cec40d388..a9bbfe2d6fb2 100644
> > > --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
> > > +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> > > @@ -75,8 +75,8 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
> > >               return rtw_read8(Adapter, EFUSE_CTRL);
> > >       } else {
> > >               return 0xFF;
> > > -
> > > -} /* rtw_efuse_read_1_byte */
> > > +     }
> > > +}/* rtw_efuse_read_1_byte */
> > >
> > >  /*  11/16/2008 MH Read one byte from real Efuse. */
> > >  u8 rtw_efuse_one_byte_read(struct adapter *padapter, u16 addr, u8 *data)
> > > --
> > > 2.34.1
> > >
> > >
> >
> > This really does not look correct at all...
> >
> > Take some time, work on this again, and resend the series to yourself to
> > see what they look like and if they make any sense or not.
> >
> > (hint, checkpatch should have complained about this one...)
> >
> > thanks,
> >
> > greg k-h

[PATCH 4/4] staging: rtl8723bs: fix missing brace in rtw_efuse_read_1_byte

[Moksh Panicker]

Fix missing brace and add space before inline comment in
rtw_efuse_read_1_byte() to comply with kernel coding style.

Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
 rtw_efuse_read_1_byte

---
 drivers/staging/rtl8723bs/core/rtw_efuse.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
index ef0cec40d388..a9bbfe2d6fb2 100644
--- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
@@ -75,8 +75,8 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
 		return rtw_read8(Adapter, EFUSE_CTRL);
 	} else {
 		return 0xFF;
-
-} /* rtw_efuse_read_1_byte */
+	}
+} /* rtw_efuse_read_1_byte */
 
 /*  11/16/2008 MH Read one byte from real Efuse. */
 u8 rtw_efuse_one_byte_read(struct adapter *padapter, u16 addr, u8 *data)
-- 
2.34.1

Re: [PATCH 4/4] staging: rtl8723bs: fix missing brace in rtw_efuse_read_1_byte

[Moksh Panicker]

HI Greg,

I re-checked the series, sent it to myself first, and compile-tested
it as well. The patches now look consistent to me and should be
correct.

Thanks,
Moksh

On Sat, May 16, 2026 at 5:04 PM Moksh Panicker
<mokshpanicker.7@gmail.com> wrote:
>
> I ran checkpatch and found the remaining issues in the cover letter
> and patch 4. I’ll fix the formatting, add the missing
> description/sign-off, and resend the cleaned series.
>
> On Sat, May 16, 2026 at 4:58 PM Moksh Panicker
> <mokshpanicker.7@gmail.com> wrote:
> >
> > Thanks, Greg. I’ll re-check the series carefully, run checkpatch on
> > each patch, and resend only after confirming the patches make sense.
> >
> > On Sat, May 16, 2026 at 4:02 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> > >
> > > On Sat, May 16, 2026 at 03:50:25PM +0000, Moksh Panicker wrote:
> > > > ---
> > > >  drivers/staging/rtl8723bs/core/rtw_efuse.c | 4 ++--
> > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> > > > index ef0cec40d388..a9bbfe2d6fb2 100644
> > > > --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
> > > > +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> > > > @@ -75,8 +75,8 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
> > > >               return rtw_read8(Adapter, EFUSE_CTRL);
> > > >       } else {
> > > >               return 0xFF;
> > > > -
> > > > -} /* rtw_efuse_read_1_byte */
> > > > +     }
> > > > +}/* rtw_efuse_read_1_byte */
> > > >
> > > >  /*  11/16/2008 MH Read one byte from real Efuse. */
> > > >  u8 rtw_efuse_one_byte_read(struct adapter *padapter, u16 addr, u8 *data)
> > > > --
> > > > 2.34.1
> > > >
> > > >
> > >
> > > This really does not look correct at all...
> > >
> > > Take some time, work on this again, and resend the series to yourself to
> > > see what they look like and if they make any sense or not.
> > >
> > > (hint, checkpatch should have complained about this one...)
> > >
> > > thanks,
> > >
> > > greg k-h

Re: [PATCH 4/4] staging: rtl8723bs: fix missing brace in rtw_efuse_read_1_byte

[Greg KH]

On Sun, May 17, 2026 at 02:37:23PM +0000, Moksh Panicker wrote:
> Fix missing brace and add space before inline comment in
> rtw_efuse_read_1_byte() to comply with kernel coding style.
> 
> Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
>  rtw_efuse_read_1_byte
> 
> ---
>  drivers/staging/rtl8723bs/core/rtw_efuse.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> index ef0cec40d388..a9bbfe2d6fb2 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> @@ -75,8 +75,8 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
>  		return rtw_read8(Adapter, EFUSE_CTRL);
>  	} else {
>  		return 0xFF;
> -
> -} /* rtw_efuse_read_1_byte */
> +	}
> +} /* rtw_efuse_read_1_byte */
>  
>  /*  11/16/2008 MH Read one byte from real Efuse. */
>  u8 rtw_efuse_one_byte_read(struct adapter *padapter, u16 addr, u8 *data)
> -- 
> 2.34.1
> 
> 

You can not break the build and then fix it in a later patch.  All
patches must never add a warning or a build breakage.

thanks,

greg k-h

Re: [PATCH 4/4] staging: rtl8723bs: fix missing brace in rtw_efuse_read_1_byte

[Dan Carpenter]

On Sat, May 16, 2026 at 03:50:25PM +0000, Moksh Panicker wrote:
> ---
>  drivers/staging/rtl8723bs/core/rtw_efuse.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> index ef0cec40d388..a9bbfe2d6fb2 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> @@ -75,8 +75,8 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
>  		return rtw_read8(Adapter, EFUSE_CTRL);
>  	} else {
>  		return 0xFF;
> -
> -} /* rtw_efuse_read_1_byte */
> +	}
> +}/* rtw_efuse_read_1_byte */
>  

This is v3 of the patchset but it's not sent in the right way.

https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

You broke the build patch 2 and you're fixing it here by adding the
closing } character.  That doesn't work.  You can't break the build.

regards,
dan carpenter