Linux kernel staging patches
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: shxyder <darknessshayder@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: octeon: fix carrier state, null guard, and modernize phy ioctl
Date: Mon, 18 May 2026 07:12:16 +0200	[thread overview]
Message-ID: <2026051852-attempt-say-7acb@gregkh> (raw)
In-Reply-To: <CANy=CjfYXx+S0o7R60TDkm6ZLifsJ9P4nDoy9JPKvWB0NpgBBg@mail.gmail.com>

On Sun, May 17, 2026 at 11:44:20AM -0500, shxyder wrote:
> Hi Greg,
> 
> Thank you for the feedback. I will split this into separate patches, one
> change per patch, and resubmit as a series.
> 
> Regarding testing: I do not have access to OCTEON hardware, so I have not
> been able to runtime test this. The changes are straightforward — adding a
> missing netif_carrier_off(), a null guard, replacing phy_mii_ioctl() with
> phy_do_ioctl_running(), and zeroing a cached field on stop. I should have
> mentioned this upfront and I apologize for not doing so.

It also looks like you did not test-build your patches, which is
generally always a requirement :)

thanks,

greg k-h

  parent reply	other threads:[~2026-05-18  5:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-17 14:19 [PATCH] net: octeon: fix carrier state, null guard, and modernize phy ioctl shayderrr
2026-05-17 14:43 ` Greg KH
     [not found]   ` <CANy=CjfYXx+S0o7R60TDkm6ZLifsJ9P4nDoy9JPKvWB0NpgBBg@mail.gmail.com>
2026-05-18  5:12     ` Greg KH [this message]
2026-05-17 19:00 ` kernel test robot
2026-05-17 21:45 ` kernel test robot
2026-05-18  5:54 ` Dan Carpenter
2026-05-18  5:55   ` Dan Carpenter
2026-05-18  5:59     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026051852-attempt-say-7acb@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=darknessshayder@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox