From: Dan Carpenter <error27@gmail.com>
To: shayderrr <darknessshayder@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: octeon: fix carrier state, null guard, and modernize phy ioctl
Date: Mon, 18 May 2026 08:54:01 +0300 [thread overview]
Message-ID: <agqpefJAG-QMcM0_@stanley.mountain> (raw)
In-Reply-To: <20260517141955.79666-1-darknessshayder@gmail.com>
On Sun, May 17, 2026 at 09:19:55AM -0500, shayderrr wrote:
> From: Pranav Bajjuri <darknessshayder@gmail.com>
>
> Add netif_carrier_off() to cvm_oct_common_stop(),
Why? Shouldn't this be in it's own patch? Do we need a Fixes tag?
> guard
> cvm_oct_adjust_link() against null phydev,
Can this really happen or is this AI advice? Shouldn't this be in
it's own patch? Do we need a Fixes tag? You have added a
WARN_ON() which basically means reboot the kernel on most systems
so it's discouraged as much as possible.
> replace open-coded
> ioctl checks with phy_do_ioctl_running(),
Put this in its own patch.
> and zero priv->link_info
> on stop alongside last_link.
Why? Shouldn't this be in it's own patch? Do we need a Fixes tag?
regards,
dan carpenter
next prev parent reply other threads:[~2026-05-18 5:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-17 14:19 [PATCH] net: octeon: fix carrier state, null guard, and modernize phy ioctl shayderrr
2026-05-17 14:43 ` Greg KH
[not found] ` <CANy=CjfYXx+S0o7R60TDkm6ZLifsJ9P4nDoy9JPKvWB0NpgBBg@mail.gmail.com>
2026-05-18 5:12 ` Greg KH
2026-05-17 19:00 ` kernel test robot
2026-05-17 21:45 ` kernel test robot
2026-05-18 5:54 ` Dan Carpenter [this message]
2026-05-18 5:55 ` Dan Carpenter
2026-05-18 5:59 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agqpefJAG-QMcM0_@stanley.mountain \
--to=error27@gmail.com \
--cc=darknessshayder@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox