* [PATCH 0/1] staging: rtl8723bs: Fix checkpatch line length warnings in xmit_linux.c
@ 2026-05-12 18:52 Pramod Maurya
2026-05-12 18:52 ` [PATCH 1/1] staging: rtl8723bs: Fix line length " Pramod Maurya
0 siblings, 1 reply; 3+ messages in thread
From: Pramod Maurya @ 2026-05-12 18:52 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, andriy.shevchenko, pramod.nexgen
This series fixes line length violations in the rtl8723bs staging driver
reported by checkpatch.pl. The two function signatures
rtw_os_xmit_resource_alloc() and rtw_os_xmit_resource_free() each exceeded
the 100 column limit. A long N_BYTE_ALIGMENT() expression was also wrapped
to comply with the limit.
Pramod Maurya (1):
staging: rtl8723bs: Fix line length in xmit_linux.c
drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
--
2.52.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] staging: rtl8723bs: Fix line length in xmit_linux.c
2026-05-12 18:52 [PATCH 0/1] staging: rtl8723bs: Fix checkpatch line length warnings in xmit_linux.c Pramod Maurya
@ 2026-05-12 18:52 ` Pramod Maurya
2026-05-21 9:21 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Pramod Maurya @ 2026-05-12 18:52 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, andriy.shevchenko, pramod.nexgen
Wrap long function signatures and a long expression to comply
with the 100 column line length limit reported by checkpatch.pl.
Signed-off-by: Pramod Maurya <pramod.nexgen@gmail.com>
---
drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/xmit_linux.c b/drivers/staging/rtl8723bs/os_dep/xmit_linux.c
index dc0b77f38b1a..1c53b7bc00c5 100644
--- a/drivers/staging/rtl8723bs/os_dep/xmit_linux.c
+++ b/drivers/staging/rtl8723bs/os_dep/xmit_linux.c
@@ -46,20 +46,25 @@ signed int rtw_endofpktfile(struct pkt_file *pfile)
return false;
}
-int rtw_os_xmit_resource_alloc(struct adapter *padapter, struct xmit_buf *pxmitbuf, u32 alloc_sz, u8 flag)
+int rtw_os_xmit_resource_alloc(struct adapter *padapter,
+ struct xmit_buf *pxmitbuf,
+ u32 alloc_sz, u8 flag)
{
if (alloc_sz > 0) {
pxmitbuf->pallocated_buf = kzalloc(alloc_sz, GFP_KERNEL);
if (!pxmitbuf->pallocated_buf)
return _FAIL;
- pxmitbuf->pbuf = (u8 *)N_BYTE_ALIGMENT((SIZE_PTR)(pxmitbuf->pallocated_buf), XMITBUF_ALIGN_SZ);
+ pxmitbuf->pbuf = (u8 *)N_BYTE_ALIGMENT((SIZE_PTR)pxmitbuf->pallocated_buf,
+ XMITBUF_ALIGN_SZ);
}
return _SUCCESS;
}
-void rtw_os_xmit_resource_free(struct adapter *padapter, struct xmit_buf *pxmitbuf, u32 free_sz, u8 flag)
+void rtw_os_xmit_resource_free(struct adapter *padapter,
+ struct xmit_buf *pxmitbuf,
+ u32 free_sz, u8 flag)
{
if (free_sz > 0)
kfree(pxmitbuf->pallocated_buf);
--
2.52.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] staging: rtl8723bs: Fix line length in xmit_linux.c
2026-05-12 18:52 ` [PATCH 1/1] staging: rtl8723bs: Fix line length " Pramod Maurya
@ 2026-05-21 9:21 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2026-05-21 9:21 UTC (permalink / raw)
To: Pramod Maurya; +Cc: linux-staging, linux-kernel, andriy.shevchenko
On Tue, May 12, 2026 at 02:52:54PM -0400, Pramod Maurya wrote:
> Wrap long function signatures and a long expression to comply
> with the 100 column line length limit reported by checkpatch.pl.
>
> Signed-off-by: Pramod Maurya <pramod.nexgen@gmail.com>
> ---
> drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/xmit_linux.c b/drivers/staging/rtl8723bs/os_dep/xmit_linux.c
> index dc0b77f38b1a..1c53b7bc00c5 100644
> --- a/drivers/staging/rtl8723bs/os_dep/xmit_linux.c
> +++ b/drivers/staging/rtl8723bs/os_dep/xmit_linux.c
> @@ -46,20 +46,25 @@ signed int rtw_endofpktfile(struct pkt_file *pfile)
> return false;
> }
>
> -int rtw_os_xmit_resource_alloc(struct adapter *padapter, struct xmit_buf *pxmitbuf, u32 alloc_sz, u8 flag)
> +int rtw_os_xmit_resource_alloc(struct adapter *padapter,
> + struct xmit_buf *pxmitbuf,
> + u32 alloc_sz, u8 flag)
> {
> if (alloc_sz > 0) {
> pxmitbuf->pallocated_buf = kzalloc(alloc_sz, GFP_KERNEL);
> if (!pxmitbuf->pallocated_buf)
> return _FAIL;
>
> - pxmitbuf->pbuf = (u8 *)N_BYTE_ALIGMENT((SIZE_PTR)(pxmitbuf->pallocated_buf), XMITBUF_ALIGN_SZ);
> + pxmitbuf->pbuf = (u8 *)N_BYTE_ALIGMENT((SIZE_PTR)pxmitbuf->pallocated_buf,
> + XMITBUF_ALIGN_SZ);
> }
>
> return _SUCCESS;
> }
>
> -void rtw_os_xmit_resource_free(struct adapter *padapter, struct xmit_buf *pxmitbuf, u32 free_sz, u8 flag)
> +void rtw_os_xmit_resource_free(struct adapter *padapter,
> + struct xmit_buf *pxmitbuf,
> + u32 free_sz, u8 flag)
> {
> if (free_sz > 0)
> kfree(pxmitbuf->pallocated_buf);
> --
> 2.52.0
>
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- Your patch did not apply to any known trees that Greg is in control
of. Possibly this is because you made it against Linus's tree, not
the linux-next tree, which is where all of the development for the
next version of the kernel is at. Please refresh your patch against
the linux-next tree, or even better yet, the development tree
specified in the MAINTAINERS file for the subsystem you are submitting
a patch for, and resend it.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-21 9:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-12 18:52 [PATCH 0/1] staging: rtl8723bs: Fix checkpatch line length warnings in xmit_linux.c Pramod Maurya
2026-05-12 18:52 ` [PATCH 1/1] staging: rtl8723bs: Fix line length " Pramod Maurya
2026-05-21 9:21 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox