[PATCH v10] staging: rtl8723bs: remove unnecessary braces in rtw_mlme.c

[PATCH v10] staging: rtl8723bs: remove unnecessary braces in rtw_mlme.c

[Ashwin Gundarapu]

From: Ashwin Gundarapu <linuxuser509@zohomail.in>
Date: Tue, 12 May 2026 17:54:37 +0530
Subject: [PATCH] staging: rtl8723bs: remove unnecessary braces in rtw_mlme.c

Remove braces around single statement blocks. Also remove an extra
blank line to maintain one blank line between statements.

Found by checkpatch.pl --strict

Signed-off-by: Ashwin Gundarapu <linuxuser509@zohomail.in>
---
v10: Removed extra blank line. Single blank line between statements only.
v9: Removed git header from email body.
v8: Fixed double blank lines as requested by Dan Carpenter.
v7: Added version changelog below the --- line.
v6: Rebased against staging-next to apply cleanly.
---
 drivers/staging/rtl8723bs/core/rtw_mlme.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index 3d88a3a185d5..22776af126ca 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -483,7 +483,6 @@ void rtw_update_scanned_network(struct adapter *adapter, struct wlan_bssid_ex *t
 			break;
 		}
 
-
 		if (rtw_roam_flags(adapter))
 			/* TODO: don't select network in the same ess as oldest if it's new enough*/
 
-- 
2.43.0

Re: [PATCH v10] staging: rtl8723bs: remove unnecessary braces in rtw_mlme.c

[Ahmet Sezgin Duran]

On 5/21/26 8:26 AM, Ashwin Gundarapu wrote:
> From: Ashwin Gundarapu <linuxuser509@zohomail.in>
> Date: Tue, 12 May 2026 17:54:37 +0530
> Subject: [PATCH] staging: rtl8723bs: remove unnecessary braces in rtw_mlme.c

This part is not supposed to be in the email. Better to use `git 
send-email` for sending patches.

> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> index 3d88a3a185d5..22776af126ca 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> @@ -483,7 +483,6 @@ void rtw_update_scanned_network(struct adapter *adapter, struct wlan_bssid_ex *t
>   			break;
>   		}
>   
> -
>   		if (rtw_roam_flags(adapter))
>   			/* TODO: don't select network in the same ess as oldest if it's new enough*/
>   

Commit message is about removing braces, but actual commit is not. You 
need to be consistent here.

Regards,
Ahmet Sezgin Duran

Re: [PATCH v10] staging: rtl8723bs: remove unnecessary braces in rtw_mlme.c

[gregkh]

On Thu, May 21, 2026 at 10:56:51AM +0530, Ashwin Gundarapu wrote:
> From: Ashwin Gundarapu <linuxuser509@zohomail.in>
> Date: Tue, 12 May 2026 17:54:37 +0530
> Subject: [PATCH] staging: rtl8723bs: remove unnecessary braces in rtw_mlme.c

This shouldn't be in the body of the email. Are you using git send-email
to send this?

> 
> Remove braces around single statement blocks. Also remove an extra
> blank line to maintain one blank line between statements.

That is not what your change did :(