* [PATCH] staging: rtl8723bs: fix operator spacing
@ 2026-05-22 0:30 omkarbhor4011
2026-05-22 4:41 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: omkarbhor4011 @ 2026-05-22 0:30 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Omkarbhor4011
From: omkarbhor4011 <Omkarbhor4011@gmail.com>
Signed-off-by: omkarbhor4011 <Omkarbhor4011@gmail.com>
---
.../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 26 +++++++++----------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
index e794fe3ca..3bb1533e1 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
@@ -21,23 +21,23 @@ static void _FWDownloadEnable(struct adapter *padapter, bool enable)
rtw_write8(padapter, REG_SYS_FUNC_EN + 1, tmp | 0x04);
tmp = rtw_read8(padapter, REG_MCUFWDL);
- rtw_write8(padapter, REG_MCUFWDL, tmp|0x01);
+ rtw_write8(padapter, REG_MCUFWDL, tmp | 0x01);
do {
tmp = rtw_read8(padapter, REG_MCUFWDL);
if (tmp & 0x01)
break;
- rtw_write8(padapter, REG_MCUFWDL, tmp|0x01);
+ rtw_write8(padapter, REG_MCUFWDL, tmp | 0x01);
msleep(1);
} while (count++ < 100);
/* 8051 reset */
- tmp = rtw_read8(padapter, REG_MCUFWDL+2);
- rtw_write8(padapter, REG_MCUFWDL+2, tmp&0xf7);
+ tmp = rtw_read8(padapter, REG_MCUFWDL + 2);
+ rtw_write8(padapter, REG_MCUFWDL + 2, tmp & 0xf7);
} else {
/* MCU firmware download disable. */
tmp = rtw_read8(padapter, REG_MCUFWDL);
- rtw_write8(padapter, REG_MCUFWDL, tmp&0xfe);
+ rtw_write8(padapter, REG_MCUFWDL, tmp & 0xfe);
}
}
@@ -70,8 +70,8 @@ static int _BlockWrite(struct adapter *padapter, void *buffer, u32 buffSize)
if (remainSize_p1) {
offset = blockCount_p1 * blockSize_p1;
- blockCount_p2 = remainSize_p1/blockSize_p2;
- remainSize_p2 = remainSize_p1%blockSize_p2;
+ blockCount_p2 = remainSize_p1 / blockSize_p2;
+ remainSize_p2 = remainSize_p1 % blockSize_p2;
}
/* 3 Phase #3 */
@@ -104,8 +104,8 @@ static int _PageWrite(
u8 value8;
u8 u8Page = (u8) (page & 0x07);
- value8 = (rtw_read8(padapter, REG_MCUFWDL+2) & 0xF8) | u8Page;
- rtw_write8(padapter, REG_MCUFWDL+2, value8);
+ value8 = (rtw_read8(padapter, REG_MCUFWDL + 2) & 0xF8) | u8Page;
+ rtw_write8(padapter, REG_MCUFWDL + 2, value8);
return _BlockWrite(padapter, buffer, size);
}
@@ -124,7 +124,7 @@ static int _WriteFW(struct adapter *padapter, void *buffer, u32 size)
for (page = 0; page < pageNums; page++) {
offset = page * MAX_DLFW_PAGE_SIZE;
- ret = _PageWrite(padapter, page, bufferPtr+offset, MAX_DLFW_PAGE_SIZE);
+ ret = _PageWrite(padapter, page, bufferPtr + offset, MAX_DLFW_PAGE_SIZE);
if (ret == _FAIL) {
netdev_dbg(padapter->pnetdev, "page write failed at %s %d\n",
@@ -136,7 +136,7 @@ static int _WriteFW(struct adapter *padapter, void *buffer, u32 size)
if (remainSize) {
offset = pageNums * MAX_DLFW_PAGE_SIZE;
page = pageNums;
- ret = _PageWrite(padapter, page, bufferPtr+offset, remainSize);
+ ret = _PageWrite(padapter, page, bufferPtr + offset, remainSize);
if (ret == _FAIL) {
netdev_dbg(padapter->pnetdev, "remaining page write failed at %s %d\n",
@@ -195,7 +195,7 @@ static s32 polling_fwdl_chksum(
if (value32 & FWDL_ChkSum_rpt || adapter->bSurpriseRemoved || adapter->bDriverStopped)
break;
yield();
- } while (jiffies_to_msecs(jiffies-start) < timeout_ms || cnt < min_cnt);
+ } while (jiffies_to_msecs(jiffies - start) < timeout_ms || cnt < min_cnt);
if (!(value32 & FWDL_ChkSum_rpt)) {
goto exit;
@@ -1888,7 +1888,7 @@ void rtl8723b_fill_fake_txdesc(
if (IsPsPoll) {
SET_TX_DESC_NAV_USE_HDR_8723B(pDesc, 1);
} else {
- SET_TX_DESC_HWSEQ_EN_8723B(pDesc, 1); /* Hw set sequence number */
+ SET_TX_DESC_HWSEQ_EN_8723B(pDesc, 1);
SET_TX_DESC_HWSEQ_SEL_8723B(pDesc, 0);
}
--
2.54.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: rtl8723bs: fix operator spacing
2026-05-22 0:30 [PATCH] staging: rtl8723bs: fix operator spacing omkarbhor4011
@ 2026-05-22 4:41 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2026-05-22 4:41 UTC (permalink / raw)
To: omkarbhor4011; +Cc: linux-staging, linux-kernel
On Fri, May 22, 2026 at 06:00:13AM +0530, omkarbhor4011@gmail.com wrote:
> From: omkarbhor4011 <Omkarbhor4011@gmail.com>
>
> Signed-off-by: omkarbhor4011 <Omkarbhor4011@gmail.com>
> ---
> .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 26 +++++++++----------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> index e794fe3ca..3bb1533e1 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> @@ -21,23 +21,23 @@ static void _FWDownloadEnable(struct adapter *padapter, bool enable)
> rtw_write8(padapter, REG_SYS_FUNC_EN + 1, tmp | 0x04);
>
> tmp = rtw_read8(padapter, REG_MCUFWDL);
> - rtw_write8(padapter, REG_MCUFWDL, tmp|0x01);
> + rtw_write8(padapter, REG_MCUFWDL, tmp | 0x01);
>
> do {
> tmp = rtw_read8(padapter, REG_MCUFWDL);
> if (tmp & 0x01)
> break;
> - rtw_write8(padapter, REG_MCUFWDL, tmp|0x01);
> + rtw_write8(padapter, REG_MCUFWDL, tmp | 0x01);
> msleep(1);
> } while (count++ < 100);
>
> /* 8051 reset */
> - tmp = rtw_read8(padapter, REG_MCUFWDL+2);
> - rtw_write8(padapter, REG_MCUFWDL+2, tmp&0xf7);
> + tmp = rtw_read8(padapter, REG_MCUFWDL + 2);
> + rtw_write8(padapter, REG_MCUFWDL + 2, tmp & 0xf7);
> } else {
> /* MCU firmware download disable. */
> tmp = rtw_read8(padapter, REG_MCUFWDL);
> - rtw_write8(padapter, REG_MCUFWDL, tmp&0xfe);
> + rtw_write8(padapter, REG_MCUFWDL, tmp & 0xfe);
> }
> }
>
> @@ -70,8 +70,8 @@ static int _BlockWrite(struct adapter *padapter, void *buffer, u32 buffSize)
> if (remainSize_p1) {
> offset = blockCount_p1 * blockSize_p1;
>
> - blockCount_p2 = remainSize_p1/blockSize_p2;
> - remainSize_p2 = remainSize_p1%blockSize_p2;
> + blockCount_p2 = remainSize_p1 / blockSize_p2;
> + remainSize_p2 = remainSize_p1 % blockSize_p2;
> }
>
> /* 3 Phase #3 */
> @@ -104,8 +104,8 @@ static int _PageWrite(
> u8 value8;
> u8 u8Page = (u8) (page & 0x07);
>
> - value8 = (rtw_read8(padapter, REG_MCUFWDL+2) & 0xF8) | u8Page;
> - rtw_write8(padapter, REG_MCUFWDL+2, value8);
> + value8 = (rtw_read8(padapter, REG_MCUFWDL + 2) & 0xF8) | u8Page;
> + rtw_write8(padapter, REG_MCUFWDL + 2, value8);
>
> return _BlockWrite(padapter, buffer, size);
> }
> @@ -124,7 +124,7 @@ static int _WriteFW(struct adapter *padapter, void *buffer, u32 size)
>
> for (page = 0; page < pageNums; page++) {
> offset = page * MAX_DLFW_PAGE_SIZE;
> - ret = _PageWrite(padapter, page, bufferPtr+offset, MAX_DLFW_PAGE_SIZE);
> + ret = _PageWrite(padapter, page, bufferPtr + offset, MAX_DLFW_PAGE_SIZE);
>
> if (ret == _FAIL) {
> netdev_dbg(padapter->pnetdev, "page write failed at %s %d\n",
> @@ -136,7 +136,7 @@ static int _WriteFW(struct adapter *padapter, void *buffer, u32 size)
> if (remainSize) {
> offset = pageNums * MAX_DLFW_PAGE_SIZE;
> page = pageNums;
> - ret = _PageWrite(padapter, page, bufferPtr+offset, remainSize);
> + ret = _PageWrite(padapter, page, bufferPtr + offset, remainSize);
>
> if (ret == _FAIL) {
> netdev_dbg(padapter->pnetdev, "remaining page write failed at %s %d\n",
> @@ -195,7 +195,7 @@ static s32 polling_fwdl_chksum(
> if (value32 & FWDL_ChkSum_rpt || adapter->bSurpriseRemoved || adapter->bDriverStopped)
> break;
> yield();
> - } while (jiffies_to_msecs(jiffies-start) < timeout_ms || cnt < min_cnt);
> + } while (jiffies_to_msecs(jiffies - start) < timeout_ms || cnt < min_cnt);
>
> if (!(value32 & FWDL_ChkSum_rpt)) {
> goto exit;
> @@ -1888,7 +1888,7 @@ void rtl8723b_fill_fake_txdesc(
> if (IsPsPoll) {
> SET_TX_DESC_NAV_USE_HDR_8723B(pDesc, 1);
> } else {
> - SET_TX_DESC_HWSEQ_EN_8723B(pDesc, 1); /* Hw set sequence number */
> + SET_TX_DESC_HWSEQ_EN_8723B(pDesc, 1);
> SET_TX_DESC_HWSEQ_SEL_8723B(pDesc, 0);
> }
>
> --
> 2.54.0
>
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- You did not specify a description of why the patch is needed, or
possibly, any description at all, in the email body. Please read the
section entitled "The canonical patch format" in the kernel file,
Documentation/process/submitting-patches.rst for what is needed in
order to properly describe the change.
- It looks like you did not use your "real" name for the patch on either
the Signed-off-by: line, or the From: line (both of which have to
match). Please read the kernel file,
Documentation/process/submitting-patches.rst for how to do this
correctly.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] staging: rtl8723bs: fix operator spacing
@ 2026-05-22 5:38 omkarbhor4011
2026-05-22 5:46 ` Dan Carpenter
2026-05-22 5:47 ` Dan Carpenter
0 siblings, 2 replies; 5+ messages in thread
From: omkarbhor4011 @ 2026-05-22 5:38 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Omkarbhor4011
From: Omkar Bhor <Omkarbhor4011@gmail.com>
Clean up operator spacing to match kernel coding style.
No functional change intended.
---
.../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 26 +++++++++----------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
index e794fe3ca..3bb1533e1 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
@@ -21,23 +21,23 @@ static void _FWDownloadEnable(struct adapter *padapter, bool enable)
rtw_write8(padapter, REG_SYS_FUNC_EN + 1, tmp | 0x04);
tmp = rtw_read8(padapter, REG_MCUFWDL);
- rtw_write8(padapter, REG_MCUFWDL, tmp|0x01);
+ rtw_write8(padapter, REG_MCUFWDL, tmp | 0x01);
do {
tmp = rtw_read8(padapter, REG_MCUFWDL);
if (tmp & 0x01)
break;
- rtw_write8(padapter, REG_MCUFWDL, tmp|0x01);
+ rtw_write8(padapter, REG_MCUFWDL, tmp | 0x01);
msleep(1);
} while (count++ < 100);
/* 8051 reset */
- tmp = rtw_read8(padapter, REG_MCUFWDL+2);
- rtw_write8(padapter, REG_MCUFWDL+2, tmp&0xf7);
+ tmp = rtw_read8(padapter, REG_MCUFWDL + 2);
+ rtw_write8(padapter, REG_MCUFWDL + 2, tmp & 0xf7);
} else {
/* MCU firmware download disable. */
tmp = rtw_read8(padapter, REG_MCUFWDL);
- rtw_write8(padapter, REG_MCUFWDL, tmp&0xfe);
+ rtw_write8(padapter, REG_MCUFWDL, tmp & 0xfe);
}
}
@@ -70,8 +70,8 @@ static int _BlockWrite(struct adapter *padapter, void *buffer, u32 buffSize)
if (remainSize_p1) {
offset = blockCount_p1 * blockSize_p1;
- blockCount_p2 = remainSize_p1/blockSize_p2;
- remainSize_p2 = remainSize_p1%blockSize_p2;
+ blockCount_p2 = remainSize_p1 / blockSize_p2;
+ remainSize_p2 = remainSize_p1 % blockSize_p2;
}
/* 3 Phase #3 */
@@ -104,8 +104,8 @@ static int _PageWrite(
u8 value8;
u8 u8Page = (u8) (page & 0x07);
- value8 = (rtw_read8(padapter, REG_MCUFWDL+2) & 0xF8) | u8Page;
- rtw_write8(padapter, REG_MCUFWDL+2, value8);
+ value8 = (rtw_read8(padapter, REG_MCUFWDL + 2) & 0xF8) | u8Page;
+ rtw_write8(padapter, REG_MCUFWDL + 2, value8);
return _BlockWrite(padapter, buffer, size);
}
@@ -124,7 +124,7 @@ static int _WriteFW(struct adapter *padapter, void *buffer, u32 size)
for (page = 0; page < pageNums; page++) {
offset = page * MAX_DLFW_PAGE_SIZE;
- ret = _PageWrite(padapter, page, bufferPtr+offset, MAX_DLFW_PAGE_SIZE);
+ ret = _PageWrite(padapter, page, bufferPtr + offset, MAX_DLFW_PAGE_SIZE);
if (ret == _FAIL) {
netdev_dbg(padapter->pnetdev, "page write failed at %s %d\n",
@@ -136,7 +136,7 @@ static int _WriteFW(struct adapter *padapter, void *buffer, u32 size)
if (remainSize) {
offset = pageNums * MAX_DLFW_PAGE_SIZE;
page = pageNums;
- ret = _PageWrite(padapter, page, bufferPtr+offset, remainSize);
+ ret = _PageWrite(padapter, page, bufferPtr + offset, remainSize);
if (ret == _FAIL) {
netdev_dbg(padapter->pnetdev, "remaining page write failed at %s %d\n",
@@ -195,7 +195,7 @@ static s32 polling_fwdl_chksum(
if (value32 & FWDL_ChkSum_rpt || adapter->bSurpriseRemoved || adapter->bDriverStopped)
break;
yield();
- } while (jiffies_to_msecs(jiffies-start) < timeout_ms || cnt < min_cnt);
+ } while (jiffies_to_msecs(jiffies - start) < timeout_ms || cnt < min_cnt);
if (!(value32 & FWDL_ChkSum_rpt)) {
goto exit;
@@ -1888,7 +1888,7 @@ void rtl8723b_fill_fake_txdesc(
if (IsPsPoll) {
SET_TX_DESC_NAV_USE_HDR_8723B(pDesc, 1);
} else {
- SET_TX_DESC_HWSEQ_EN_8723B(pDesc, 1); /* Hw set sequence number */
+ SET_TX_DESC_HWSEQ_EN_8723B(pDesc, 1);
SET_TX_DESC_HWSEQ_SEL_8723B(pDesc, 0);
}
--
2.54.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: rtl8723bs: fix operator spacing
2026-05-22 5:38 omkarbhor4011
@ 2026-05-22 5:46 ` Dan Carpenter
2026-05-22 5:47 ` Dan Carpenter
1 sibling, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2026-05-22 5:46 UTC (permalink / raw)
To: omkarbhor4011; +Cc: gregkh, linux-staging, linux-kernel
On Fri, May 22, 2026 at 11:08:54AM +0530, omkarbhor4011@gmail.com wrote:
> @@ -1888,7 +1888,7 @@ void rtl8723b_fill_fake_txdesc(
> if (IsPsPoll) {
> SET_TX_DESC_NAV_USE_HDR_8723B(pDesc, 1);
> } else {
> - SET_TX_DESC_HWSEQ_EN_8723B(pDesc, 1); /* Hw set sequence number */
> + SET_TX_DESC_HWSEQ_EN_8723B(pDesc, 1);
Why delete the comment?
regards,
dan carpenter
> SET_TX_DESC_HWSEQ_SEL_8723B(pDesc, 0);
> }
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: rtl8723bs: fix operator spacing
2026-05-22 5:38 omkarbhor4011
2026-05-22 5:46 ` Dan Carpenter
@ 2026-05-22 5:47 ` Dan Carpenter
1 sibling, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2026-05-22 5:47 UTC (permalink / raw)
To: omkarbhor4011; +Cc: gregkh, linux-staging, linux-kernel
On Fri, May 22, 2026 at 11:08:54AM +0530, omkarbhor4011@gmail.com wrote:
> From: Omkar Bhor <Omkarbhor4011@gmail.com>
>
> Clean up operator spacing to match kernel coding style.
>
> No functional change intended.
> ---
Run your patches through checkpatch. Wait a day between resends.
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-05-22 5:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-22 0:30 [PATCH] staging: rtl8723bs: fix operator spacing omkarbhor4011
2026-05-22 4:41 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2026-05-22 5:38 omkarbhor4011
2026-05-22 5:46 ` Dan Carpenter
2026-05-22 5:47 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox