[PATCH] staging: rtl8723bs: remove redundant parentheses

[PATCH] staging: rtl8723bs: remove redundant parentheses

[Ben O'Bryan]

Remove redundant parentheses around type checks
and align conditional lines to improve readability

Signed-off-by: Ben O'Bryan <obryanbw@gmail.com>
---

This is my first patch to the kernel so please let me know if
I've done anything wrong.

This patch is mostly for me to verify my environment. Assuming
everything goes smoothly, I hope to continue to contribute
more formatting patches as I get more comfortable contributing.

 drivers/staging/rtl8723bs/core/rtw_xmit.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
index 444966c0de7f..cc38c0c950bb 100644
--- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
+++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
@@ -2476,9 +2476,9 @@ struct xmit_buf *dequeue_pending_xmitbuf_under_survey(struct xmit_priv *pxmitpri
 
 			type = GetFrameSubType(pxmitbuf->pbuf + TXDESC_OFFSET);
 
-			if ((type == WIFI_PROBEREQ) ||
-				(type == WIFI_DATA_NULL) ||
-				(type == WIFI_QOS_DATA_NULL)) {
+			if (type == WIFI_PROBEREQ ||
+			    type == WIFI_DATA_NULL ||
+			    type == WIFI_QOS_DATA_NULL) {
 				list_del_init(&pxmitbuf->list);
 				break;
 			}
-- 
2.52.0

Re: [PATCH] staging: rtl8723bs: remove redundant parentheses

[Dan Carpenter]

On Sat, May 30, 2026 at 07:41:03PM -0500, Ben O'Bryan wrote:
> Remove redundant parentheses around type checks
> and align conditional lines to improve readability
> 
> Signed-off-by: Ben O'Bryan <obryanbw@gmail.com>
> ---
> 
> This is my first patch to the kernel so please let me know if
> I've done anything wrong.
> 
> This patch is mostly for me to verify my environment. Assuming
> everything goes smoothly, I hope to continue to contribute
> more formatting patches as I get more comfortable contributing.
> 

We don't mind the extra parentheses in staging so we disabled
that checkpatch warning.

regards,
dan carpenter

[PATCH] staging: rtl8723bs: remove redundant & parentheses

[Sam Daly]

Remove redundant parentheses around the '&' operator to comply with
kernel style guidelines, as reported by checkpatch:
CHECK: Unnecessary parentheses around adapter->securitypriv

Signed-off-by: Sam Daly <sam@samdaly.ie>
---
 drivers/staging/rtl8723bs/core/rtw_security.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core/rtw_security.c
index 4edcbd95aab3..a00504ff2910 100644
--- a/drivers/staging/rtl8723bs/core/rtw_security.c
+++ b/drivers/staging/rtl8723bs/core/rtw_security.c
@@ -1456,7 +1456,7 @@ int omac1_aes_128(u8 *key, u8 *data, size_t data_len, u8 *mac)
 /* Restore HW wep key setting according to key_mask */
 void rtw_sec_restore_wep_key(struct adapter *adapter)
 {
-	struct security_priv *securitypriv = &(adapter->securitypriv);
+	struct security_priv *securitypriv = &adapter->securitypriv;
 	signed int keyid;
 
 	if ((securitypriv->dot11PrivacyAlgrthm == _WEP40_) || (securitypriv->dot11PrivacyAlgrthm == _WEP104_)) {
@@ -1473,7 +1473,7 @@ void rtw_sec_restore_wep_key(struct adapter *adapter)
 
 u8 rtw_handle_tkip_countermeasure(struct adapter *adapter, const char *caller)
 {
-	struct security_priv *securitypriv = &(adapter->securitypriv);
+	struct security_priv *securitypriv = &adapter->securitypriv;
 	u8 status = _SUCCESS;
 
 	if (securitypriv->btkip_countermeasure) {
-- 
2.53.0

Re: [PATCH] staging: rtl8723bs: remove redundant & parentheses

[Ethan Tidmore]

On Fri Apr 3, 2026 at 12:28 PM CDT, Sam Daly wrote:
> Remove redundant parentheses around the '&' operator to comply with
> kernel style guidelines, as reported by checkpatch:
> CHECK: Unnecessary parentheses around adapter->securitypriv
>
> Signed-off-by: Sam Daly <sam@samdaly.ie>
> ---

LGTM.

Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>

Thanks,

ET