Re: [PATCH v2] staging: iio: addac: fix CamelCase naming in adt7316

[Jonathan Cameron <jic23@kernel.org>]

On Wed, 3 Jun 2026 09:32:13 +0300
Dan Carpenter <error27@gmail.com> wrote:

> On Tue, Jun 02, 2026 at 08:03:08PM +0100, Jad Keskes wrote:
> > checkpatch flagged a few CamelCase names in this driver.
> > AIN and DAC prefixes are lowercased as standard kernel style.  
> 
> The AIN things aren't an issue and checkpatch doesn't complain
> about them.

Also they are userspace ABI.  Admittedly this is in staging and that
ABI is completely none compliant with IIO standards, but none the less
you should be very very careful when making that sort of change.

This driver needs a mass of work to drag it into the modern age.
IIRC there have been a few partial attempts at that in the past.
One key part of that is most of what you are touching in this
patch is in code that will not exist after this is modernized.

I'd be surprised if there is low hanging fruit like this that actually
makes sense to do in the remaining staging/iio drivers. 
Mostly much more radical surgery is required.

Anyhow, with that all in mind I'm not planning to take this sort
of change to this driver

Jonathan

> 
> > Vref is kept capitalized since V stands for Voltage and is a
> > proper technical abbreviation.
> > 
> > DA_AB and DA_CD are renamed to dac_ab and dac_cd to match the
> > register constants ADT7316_VREF_BYPASS_DAC_AB and
> > ADT7316_VREF_BYPASS_DAC_CD that they reference.  
> 
> This sort of change would need to be in its own commit.  (We're
> dropping the rest of the commit anyway).  The difference
> between DA and DAC is not totally clear to me...  The
> adt7316_show_DAC_2Vref_ch_mask() function only seems to deal
> with DA but the adt7316_store_DAC_2Vref_ch_mask() does stuff
> with both.  So I'm not sure I understand the naming.  (I have
> not investigated and this is my first time to look at this
> code).
> 
> regards,
> dan carpenter
>