From: Dan Carpenter <error27@gmail.com>
To: Jad Keskes <inasj268@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-iio@vger.kernel.org,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH v2] staging: iio: addac: fix CamelCase naming in adt7316
Date: Wed, 3 Jun 2026 09:32:13 +0300 [thread overview]
Message-ID: <ah_Kbff-c38NWV66@stanley.mountain> (raw)
In-Reply-To: <20260602190308.158051-1-inasj268@gmail.com>
On Tue, Jun 02, 2026 at 08:03:08PM +0100, Jad Keskes wrote:
> checkpatch flagged a few CamelCase names in this driver.
> AIN and DAC prefixes are lowercased as standard kernel style.
The AIN things aren't an issue and checkpatch doesn't complain
about them.
> Vref is kept capitalized since V stands for Voltage and is a
> proper technical abbreviation.
>
> DA_AB and DA_CD are renamed to dac_ab and dac_cd to match the
> register constants ADT7316_VREF_BYPASS_DAC_AB and
> ADT7316_VREF_BYPASS_DAC_CD that they reference.
This sort of change would need to be in its own commit. (We're
dropping the rest of the commit anyway). The difference
between DA and DAC is not totally clear to me... The
adt7316_show_DAC_2Vref_ch_mask() function only seems to deal
with DA but the adt7316_store_DAC_2Vref_ch_mask() does stuff
with both. So I'm not sure I understand the naming. (I have
not investigated and this is my first time to look at this
code).
regards,
dan carpenter
next prev parent reply other threads:[~2026-06-03 6:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 19:03 [PATCH v2] staging: iio: addac: fix CamelCase naming in adt7316 Jad Keskes
2026-06-03 6:32 ` Dan Carpenter [this message]
2026-06-03 11:00 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ah_Kbff-c38NWV66@stanley.mountain \
--to=error27@gmail.com \
--cc=inasj268@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox