* [PATCH v3] media: atomisp: gmin: Use str_on_off() helper
@ 2026-06-11 7:28 Mert Seftali
0 siblings, 0 replies; only message in thread
From: Mert Seftali @ 2026-06-11 7:28 UTC (permalink / raw)
To: Hans de Goede, Mauro Carvalho Chehab
Cc: Andy Shevchenko, Kees Cook, Sakari Ailus, Greg Kroah-Hartman,
linux-media, linux-staging, linux-kernel, Mert Seftali
Replace the open-coded "on" : "off" ternary with the standard
str_on_off() helper from <linux/string_choices.h>. This improves
readability and reuses the kernel's existing string helper instead of
duplicating the literals.
No functional change intended.
Signed-off-by: Mert Seftali <mertsftl@gmail.com>
Reviewed-by: Kees Cook <kees@kernel.org>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
---
Changes in v3:
- Collect Reviewed-by tag from Kees Cook.
- No code changes since v2.
drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
index 4026e98c5845..cb60cb3fab48 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
@@ -13,6 +13,8 @@
#include <linux/gpio/consumer.h>
#include <linux/gpio.h>
#include <linux/platform_device.h>
+#include <linux/string_choices.h>
+
#include "../../include/linux/atomisp_platform.h"
#include "../../include/linux/atomisp_gmin_platform.h"
@@ -916,8 +918,7 @@ static int gmin_acpi_pm_ctrl(struct v4l2_subdev *subdev, int on)
if (gs->clock_on == on)
return 0;
- dev_dbg(subdev->dev, "Setting power state to %s\n",
- on ? "on" : "off");
+ dev_dbg(subdev->dev, "Setting power state to %s\n", str_on_off(on));
if (on)
ret = acpi_device_set_power(adev,
@@ -930,7 +931,7 @@ static int gmin_acpi_pm_ctrl(struct v4l2_subdev *subdev, int on)
gs->clock_on = on;
else
dev_err(subdev->dev, "Couldn't set power state to %s\n",
- on ? "on" : "off");
+ str_on_off(on));
return ret;
}
--
2.54.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-06-11 7:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-11 7:28 [PATCH v3] media: atomisp: gmin: Use str_on_off() helper Mert Seftali
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox