Linux kernel staging patches
 help / color / mirror / Atom feed
* [QUESTION] staging: octeon: is the FIXME in cvm_oct_sgmii_init stale?
@ 2026-06-17 21:07 Pablo D. Bergamasco
  0 siblings, 0 replies; only message in thread
From: Pablo D. Bergamasco @ 2026-06-17 21:07 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: linux-staging, linux-kernel, danpablo

Hi Greg,

While looking at drivers/staging/octeon/ethernet-sgmii.c I noticed
a FIXME comment in cvm_oct_sgmii_init():

    cvm_oct_common_init(dev);
    /* FIXME: Need autoneg logic */
    return 0;

After tracing the code, I believe autoneg is already handled when
the interface is opened:

  cvm_oct_sgmii_open()
      -> cvm_oct_common_open()
          -> cvm_oct_phy_setup_device()
              -> phy_start()
                  -> phy_state_machine()
                      -> _phy_start_aneg()
                          -> genphy_config_aneg()

Is my analysis correct? If so, should I send a patch to remove
the stale FIXME comment?

Thanks,
Pablo D. Bergamasco

^ permalink raw reply	[flat|nested] only message in thread
only message in thread, other threads:[~2026-06-17 21:07 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-17 21:07 [QUESTION] staging: octeon: is the FIXME in cvm_oct_sgmii_init stale? Pablo D. Bergamasco

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox