[PATCH] staging: media: atomisp: use %s with __func__ in debug messages

[PATCH] staging: media: atomisp: use %s with __func__ in debug messages

[Ambar Chakravartty]

This patch fixes the following checkpatch.pl warning:
Prefer using '"%s...", __func__' to using 'ia_css_bayer_io_config',
this function's name, in a string

Signed-off-by: Ambar Chakravartty <amch9605@gmail.com>
---
 .../kernels/ipu2_io_ls/bayer_io_ls/ia_css_bayer_io.host.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/ipu2_io_ls/bayer_io_ls/ia_css_bayer_io.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/ipu2_io_ls/bayer_io_ls/ia_css_bayer_io.host.c
index 38f371b6d6d5..cc2179c5bb89 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/ipu2_io_ls/bayer_io_ls/ia_css_bayer_io.host.c
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/ipu2_io_ls/bayer_io_ls/ia_css_bayer_io.host.c
@@ -39,7 +39,7 @@ int ia_css_bayer_io_config(const struct ia_css_binary      *binary,
 		struct dma_port_config config;
 #ifndef IA_CSS_NO_DEBUG
 		ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE,
-				    "ia_css_bayer_io_config() get part enter:\n");
+				    "%s get part enter:\n", __func__);
 #endif
 
 		ret = ia_css_dma_configure_from_info(&config, in_frame_info);
@@ -52,7 +52,7 @@ int ia_css_bayer_io_config(const struct ia_css_binary      *binary,
 		to->ddr_elems_per_word = ddr_elems_per_word;
 #ifndef IA_CSS_NO_DEBUG
 		ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE,
-				    "ia_css_bayer_io_config() get part leave:\n");
+				    "%s get part leave:\n", __func__);
 #endif
 	}
 
@@ -67,7 +67,7 @@ int ia_css_bayer_io_config(const struct ia_css_binary      *binary,
 		struct dma_port_config config;
 #ifndef IA_CSS_NO_DEBUG
 		ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE,
-				    "ia_css_bayer_io_config() put part enter:\n");
+				    "%s put part enter:\n", __func__);
 #endif
 
 		ret = ia_css_dma_configure_from_info(&config, &out_frames[0]->frame_info);
@@ -81,7 +81,7 @@ int ia_css_bayer_io_config(const struct ia_css_binary      *binary,
 
 #ifndef IA_CSS_NO_DEBUG
 		ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE,
-				    "ia_css_bayer_io_config() put part leave:\n");
+				    "%s put part leave:\n", __func__);
 #endif
 	}
 	return 0;
-- 
2.54.0

Re: [PATCH] staging: media: atomisp: use %s with __func__ in debug messages

[Andy Shevchenko]

On Tue, Jun 23, 2026 at 8:47 AM Ambar Chakravartty <amch9605@gmail.com> wrote:
>
> This patch fixes the following checkpatch.pl warning:
> Prefer using '"%s...", __func__' to using 'ia_css_bayer_io_config',
> this function's name, in a strin

No, please read the linux-media mailing list archives regarding this
driver and recent (past few months) submissions.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] staging: media: atomisp: use %s with __func__ in debug messages

[Ambar Chakravartty]

Thanks for the review.

I found the recent discussions in the linux-media archives regarding
moving from the current debugging messages to tracepoints and trace 
events.

Please disregard this patch.

--
Regards,
Ambar