* [PATCH] staging: rtl8723bs: rename shadowed variable
@ 2026-06-25 15:16 Aditya Tipre
0 siblings, 0 replies; only message in thread
From: Aditya Tipre @ 2026-06-25 15:16 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Ethan Tidmore, Rohan Tripathi, Nikolay Kulikov, Dan Carpenter,
Minu Jin, linux-staging, linux-kernel, Aditya Tipre
The inner variable ie in update_bcn_erpinfo_ie() shadows an outer local
variable of the same name. This triggers a -Wshadow warning.
Rename the inner variable to erp_ie to remove the warning
and make the code less ambiguous.
No functional change.
Signed-off-by: Aditya Tipre <tipreaditya@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_ap.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index 065850a9e894..a86685922913 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -1307,20 +1307,21 @@ static void update_bcn_erpinfo_ie(struct adapter *padapter)
&len,
(pnetwork->ie_length - _BEACON_IE_OFFSET_));
if (p && len > 0) {
- struct ndis_80211_var_ie *ie = (struct ndis_80211_var_ie *)p;
+ struct ndis_80211_var_ie *erp_ie = (struct ndis_80211_var_ie *)p;
if (pmlmepriv->num_sta_non_erp == 1)
- ie->data[0] |= RTW_ERP_INFO_NON_ERP_PRESENT | RTW_ERP_INFO_USE_PROTECTION;
+ erp_ie->data[0] |= RTW_ERP_INFO_NON_ERP_PRESENT |
+ RTW_ERP_INFO_USE_PROTECTION;
else
- ie->data[0] &= ~(RTW_ERP_INFO_NON_ERP_PRESENT |
- RTW_ERP_INFO_USE_PROTECTION);
+ erp_ie->data[0] &= ~(RTW_ERP_INFO_NON_ERP_PRESENT |
+ RTW_ERP_INFO_USE_PROTECTION);
if (pmlmepriv->num_sta_no_short_preamble > 0)
- ie->data[0] |= RTW_ERP_INFO_BARKER_PREAMBLE_MODE;
+ erp_ie->data[0] |= RTW_ERP_INFO_BARKER_PREAMBLE_MODE;
else
- ie->data[0] &= ~(RTW_ERP_INFO_BARKER_PREAMBLE_MODE);
+ erp_ie->data[0] &= ~(RTW_ERP_INFO_BARKER_PREAMBLE_MODE);
- ERP_IE_handler(padapter, ie);
+ ERP_IE_handler(padapter, erp_ie);
}
}
--
2.54.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-06-25 15:17 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-25 15:16 [PATCH] staging: rtl8723bs: rename shadowed variable Aditya Tipre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox