From: Freeman Yuan <freemanyuan15@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Freeman Yuan <freemanyuan15@gmail.com>
Subject: [PATCH] staging: rtl8723bs: fix cmdThread CamelCase style warning
Date: Fri, 3 Jul 2026 20:41:52 -0700 [thread overview]
Message-ID: <20260704034152.115006-1-freemanyuan15@gmail.com> (raw)
Rename the CamelCase variable structure member cmdThread to cmd_thread
inside drv_types.h and rtw_cmd.c to align with standard Linux kernel
coding style guidelines.
From: Freeman Yuan <freemanyuan15@gmail.com>
Subject: [PATCH] staging: rtl8723bs: fix cmdThread CamelCase style warning
Rename the CamelCase variable structure member cmdThread to cmd_thread
inside drv_types.h and rtw_cmd.c to align with standard Linux kernel
coding style guidelines.
Signed-off-by: Your Real Name <freemanyuan15@gmail.com>
---
--- a/drivers/staging/rtl8723bs/include/drv_types.h 2026-06-28 12:01:31.000000000 -0700
+++ b/drivers/staging/rtl8723bs/include/drv_types.h 2026-07-03 20:13:13.040001710 -0700
@@ -307,7 +307,7 @@
u8 init_adpt_in_progress;
u8 bHaltInProgress;
- void *cmdThread;
+ void *cmd_thread;
void *evtThread;
void *xmitThread;
void *recvThread;
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c 2026-06-28 12:01:31.000000000 -0700
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c 2026-07-03 20:13:13.046001687 -0700
@@ -11,7 +11,7 @@
#include <linux/delay.h>
static struct _cmd_callback rtw_cmd_callback[] = {
- {GEN_CMD_CODE(_Read_MACREG), NULL}, /*0*/
+ {GEN_CMD_CODE(read_macreg), NULL}, /*0*/
{GEN_CMD_CODE(_Write_MACREG), NULL},
{GEN_CMD_CODE(_Read_BBREG), &rtw_getbbrfreg_cmdrsp_callback},
{GEN_CMD_CODE(_Write_BBREG), NULL},
@@ -163,7 +163,7 @@
int rtw_init_cmd_priv(struct cmd_priv *pcmdpriv)
{
init_completion(&pcmdpriv->cmd_queue_comp);
- init_completion(&pcmdpriv->terminate_cmdthread_comp);
+ init_completion(&pcmdpriv->terminate_cmd_thread_comp);
INIT_LIST_HEAD(&pcmdpriv->cmd_queue.queue);
spin_lock_init(&pcmdpriv->cmd_queue.lock);
@@ -363,12 +363,12 @@
void rtw_stop_cmd_thread(struct adapter *adapter)
{
- if (adapter->cmdThread &&
+ if (adapter->cmd_thread &&
atomic_read(&adapter->cmdpriv.cmdthd_running) &&
adapter->cmdpriv.stop_req == 0) {
adapter->cmdpriv.stop_req = 1;
complete(&adapter->cmdpriv.cmd_queue_comp);
- wait_for_completion(&adapter->cmdpriv.terminate_cmdthread_comp);
+ wait_for_completion(&adapter->cmdpriv.terminate_cmd_thread_comp);
}
}
@@ -389,7 +389,7 @@
pcmdpriv->stop_req = 0;
atomic_set(&pcmdpriv->cmdthd_running, true);
- complete(&pcmdpriv->terminate_cmdthread_comp);
+ complete(&pcmdpriv->terminate_cmd_thread_comp);
while (1) {
if (wait_for_completion_interruptible(&pcmdpriv->cmd_queue_comp)) {
@@ -511,7 +511,7 @@
rtw_free_cmd_obj(pcmd);
} while (1);
- complete(&pcmdpriv->terminate_cmdthread_comp);
+ complete(&pcmdpriv->terminate_cmd_thread_comp);
atomic_set(&pcmdpriv->cmdthd_running, false);
return 0;
next reply other threads:[~2026-07-04 3:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-04 3:41 Freeman Yuan [this message]
2026-07-04 6:40 ` [PATCH] staging: rtl8723bs: fix cmdThread CamelCase style warning Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260704034152.115006-1-freemanyuan15@gmail.com \
--to=freemanyuan15@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox