[PATCH] staging: rtl8723bs: fix cmdThread CamelCase style warning

[PATCH] staging: rtl8723bs: fix cmdThread CamelCase style warning

[Freeman Yuan]

Rename the CamelCase variable structure member cmdThread to cmd_thread
inside drv_types.h and rtw_cmd.c to align with standard Linux kernel
coding style guidelines.
From: Freeman Yuan <freemanyuan15@gmail.com>
Subject: [PATCH] staging: rtl8723bs: fix cmdThread CamelCase style warning

Rename the CamelCase variable structure member cmdThread to cmd_thread
inside drv_types.h and rtw_cmd.c to align with standard Linux kernel
coding style guidelines.

Signed-off-by: Your Real Name <freemanyuan15@gmail.com>

---











--- a/drivers/staging/rtl8723bs/include/drv_types.h	2026-06-28 12:01:31.000000000 -0700
+++ b/drivers/staging/rtl8723bs/include/drv_types.h	2026-07-03 20:13:13.040001710 -0700
@@ -307,7 +307,7 @@
 	u8 init_adpt_in_progress;
 	u8 bHaltInProgress;
 
-	void *cmdThread;
+	void *cmd_thread;
 	void *evtThread;
 	void *xmitThread;
 	void *recvThread;
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c	2026-06-28 12:01:31.000000000 -0700
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c	2026-07-03 20:13:13.046001687 -0700
@@ -11,7 +11,7 @@
 #include <linux/delay.h>
 
 static struct _cmd_callback rtw_cmd_callback[] = {
-	{GEN_CMD_CODE(_Read_MACREG), NULL}, /*0*/
+	{GEN_CMD_CODE(read_macreg), NULL}, /*0*/
 	{GEN_CMD_CODE(_Write_MACREG), NULL},
 	{GEN_CMD_CODE(_Read_BBREG), &rtw_getbbrfreg_cmdrsp_callback},
 	{GEN_CMD_CODE(_Write_BBREG), NULL},
@@ -163,7 +163,7 @@
 int rtw_init_cmd_priv(struct	cmd_priv *pcmdpriv)
 {
 	init_completion(&pcmdpriv->cmd_queue_comp);
-	init_completion(&pcmdpriv->terminate_cmdthread_comp);
+	init_completion(&pcmdpriv->terminate_cmd_thread_comp);
 
 	INIT_LIST_HEAD(&pcmdpriv->cmd_queue.queue);
 	spin_lock_init(&pcmdpriv->cmd_queue.lock);
@@ -363,12 +363,12 @@
 
 void rtw_stop_cmd_thread(struct adapter *adapter)
 {
-	if (adapter->cmdThread &&
+	if (adapter->cmd_thread &&
 	    atomic_read(&adapter->cmdpriv.cmdthd_running) &&
 		adapter->cmdpriv.stop_req == 0) {
 		adapter->cmdpriv.stop_req = 1;
 		complete(&adapter->cmdpriv.cmd_queue_comp);
-		wait_for_completion(&adapter->cmdpriv.terminate_cmdthread_comp);
+		wait_for_completion(&adapter->cmdpriv.terminate_cmd_thread_comp);
 	}
 }
 
@@ -389,7 +389,7 @@
 
 	pcmdpriv->stop_req = 0;
 	atomic_set(&pcmdpriv->cmdthd_running, true);
-	complete(&pcmdpriv->terminate_cmdthread_comp);
+	complete(&pcmdpriv->terminate_cmd_thread_comp);
 
 	while (1) {
 		if (wait_for_completion_interruptible(&pcmdpriv->cmd_queue_comp)) {
@@ -511,7 +511,7 @@
 		rtw_free_cmd_obj(pcmd);
 	} while (1);
 
-	complete(&pcmdpriv->terminate_cmdthread_comp);
+	complete(&pcmdpriv->terminate_cmd_thread_comp);
 	atomic_set(&pcmdpriv->cmdthd_running, false);
 
 	return 0;

Re: [PATCH] staging: rtl8723bs: fix cmdThread CamelCase style warning

[Greg KH]

On Fri, Jul 03, 2026 at 08:41:52PM -0700, Freeman Yuan wrote:
> Rename the CamelCase variable structure member cmdThread to cmd_thread
> inside drv_types.h and rtw_cmd.c to align with standard Linux kernel
> coding style guidelines.
> From: Freeman Yuan <freemanyuan15@gmail.com>
> Subject: [PATCH] staging: rtl8723bs: fix cmdThread CamelCase style warning
> 
> Rename the CamelCase variable structure member cmdThread to cmd_thread
> inside drv_types.h and rtw_cmd.c to align with standard Linux kernel
> coding style guidelines.
> 
> Signed-off-by: Your Real Name <freemanyuan15@gmail.com>

Interesting name :)