Linux kernel staging patches
 help / color / mirror / Atom feed
* [PATCH] staging: axis-fifo: fix wait_event_interruptable() continuation alignment
@ 2026-05-25 12:01 Condition00
  2026-07-07 10:02 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Condition00 @ 2026-05-25 12:01 UTC (permalink / raw)
  To: gregkh
  Cc: linux-staging, linux-kernel, ovidiu.panait.oss, error27,
	gustavopiazdasilva2102, Condition00

Fixed the continuation indentation in axis-fifo_write() so the code matches
the kernel style and passes the checks by scripts/checkpatch.pl.

Signed-off-by: Condition00 <anant.kavuru@gmail.com>
---
 drivers/staging/axis-fifo/axis-fifo.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
index 3aa2aa870ea9..7b96be052c55 100644
--- a/drivers/staging/axis-fifo/axis-fifo.c
+++ b/drivers/staging/axis-fifo/axis-fifo.c
@@ -246,7 +246,9 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
 		mutex_lock(&fifo->write_lock);
 
 		ret = wait_event_interruptible(fifo->write_queue,
-			ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >= words_to_write);
+					       ioread32(fifo->base_addr +
+							   XLLF_TDFV_OFFSET) >=
+					       words_to_write);
 		if (ret)
 			goto end_unlock;
 	}
-- 
2.54.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: axis-fifo: fix wait_event_interruptable() continuation alignment
  2026-05-25 12:01 [PATCH] staging: axis-fifo: fix wait_event_interruptable() continuation alignment Condition00
@ 2026-07-07 10:02 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2026-07-07 10:02 UTC (permalink / raw)
  To: Condition00
  Cc: linux-staging, linux-kernel, ovidiu.panait.oss, error27,
	gustavopiazdasilva2102

On Mon, May 25, 2026 at 05:31:16PM +0530, Condition00 wrote:
> Fixed the continuation indentation in axis-fifo_write() so the code matches
> the kernel style and passes the checks by scripts/checkpatch.pl.
> 
> Signed-off-by: Condition00 <anant.kavuru@gmail.com>

Real name please.

But:

> ---
>  drivers/staging/axis-fifo/axis-fifo.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
> index 3aa2aa870ea9..7b96be052c55 100644
> --- a/drivers/staging/axis-fifo/axis-fifo.c
> +++ b/drivers/staging/axis-fifo/axis-fifo.c
> @@ -246,7 +246,9 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
>  		mutex_lock(&fifo->write_lock);
>  
>  		ret = wait_event_interruptible(fifo->write_queue,
> -			ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >= words_to_write);
> +					       ioread32(fifo->base_addr +
> +							   XLLF_TDFV_OFFSET) >=
> +					       words_to_write);

Isn't this now harder to understand?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-07-07 10:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-25 12:01 [PATCH] staging: axis-fifo: fix wait_event_interruptable() continuation alignment Condition00
2026-07-07 10:02 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox