[PATCH] staging: rtl8723bs: fix checkpatch style issues

[PATCH] staging: rtl8723bs: fix checkpatch style issues

[MrXploisLite]

Fix minor style issues in hal_com.c reported by checkpatch:
- Remove multiple blank lines
- Remove blank line after open brace
- Fix comparison style (constant on right side)

No functional changes, only coding style fixes.

Signed-off-by: MrXploisLite <arokigaming@gmail.com>
---
 drivers/staging/rtl8723bs/hal/hal_com.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c
index 50370b14c..1298ab2e5 100644
--- a/drivers/staging/rtl8723bs/hal/hal_com.c
+++ b/drivers/staging/rtl8723bs/hal/hal_com.c
@@ -30,7 +30,6 @@ void rtw_hal_data_deinit(struct adapter *padapter)
 	}
 }
 
-
 void dump_chip_info(struct hal_version	ChipVersion)
 {
 	char buf[128];
@@ -71,7 +70,6 @@ void dump_chip_info(struct hal_version	ChipVersion)
 	cnt += scnprintf(buf + cnt, sizeof(buf) - cnt, "RomVer(%d)\n", ChipVersion.ROMVer);
 }
 
-
 #define	EEPROM_CHANNEL_PLAN_BY_HW_MASK	0x80
 
 /*
@@ -107,7 +105,7 @@ u8 hal_com_config_channel_plan(
 	pHalData->bDisableSWChannelPlan = false;
 	chnlPlan = def_channel_plan;
 
-	if (0xFF == hw_channel_plan)
+	if (hw_channel_plan == 0xFF)
 		AutoLoadFail = true;
 
 	if (!AutoLoadFail) {
@@ -294,7 +292,6 @@ void HalSetBrateCfg(struct adapter *Adapter, u8 *mBratesOS, u16 *pBrateCfg)
 	u8 i, is_brate, brate;
 
 	for (i = 0; i < NDIS_802_11_LENGTH_RATES_EX; i++) {
-
 		is_brate = mBratesOS[i] & IEEE80211_BASIC_RATE_MASK;
 		brate = mBratesOS[i] & 0x7f;
 
-- 
2.53.0

Re: [PATCH] staging: rtl8723bs: fix checkpatch style issues

[Ethan Tidmore]

On Wed Mar 25, 2026 at 6:45 PM CDT, MrXploisLite wrote:
> Fix minor style issues in hal_com.c reported by checkpatch:
> - Remove multiple blank lines
> - Remove blank line after open brace
> - Fix comparison style (constant on right side)
>
> No functional changes, only coding style fixes.
>
> Signed-off-by: MrXploisLite <arokigaming@gmail.com>
> ---

You need to use your real name when submitting patches. Also, don't use
the name of the tool in your subject, it should be something like
"Remove unneeded blank lines".

...

> -	if (0xFF == hw_channel_plan)
> +	if (hw_channel_plan == 0xFF)
>  		AutoLoadFail = true;

Please keep one logical change per patch. The removal of blank lines and
correcting comparison orientation are two different changes.

Use "$ ./scripts/checkpatch.pl --strict <patch>" too before sending
patches off, it helps catch a lot of easy mistakes.

Thanks,

ET

[PATCH] staging: rtl8723bs: fix checkpatch style issues

[Saulo Henrique]

From 66175877cefddce1a2ea5ee2cffec427c05b21d2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Saulo=20Henrique=20Santos=20Dorot=C3=A9io?=
 <doroteios@outlook.com>
Date: Sat, 20 Jun 2026 19:29:24 -0300
Subject: [PATCH] staging: rtl8723bs: fix checkpatch style issues
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Fix multiple coding styles issues reported by checkpatch.pl, including
line wrapping and whitespace cleanup.

Signed-off-by: Saulo Henrique Santos Dorotéio <doroteios@outlook.com>
---
 drivers/staging/rtl8723bs/core/rtw_btcoex.c | 5 ++---
 drivers/staging/rtl8723bs/core/rtw_efuse.c | 4 ++--
 drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 14 +++++++-------
 drivers/staging/rtl8723bs/core/rtw_mlme.c | 4 ++--
 4 files changed, 13 insertions(+), 14 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_btcoex.c
b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
index 0191a943f..055ca95ff 100644
--- a/drivers/staging/rtl8723bs/core/rtw_btcoex.c
+++ b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
@@ -10,8 +10,8 @@

 void rtw_btcoex_MediaStatusNotify(struct adapter *padapter, u8 media_status)
 {
- if ((media_status == RT_MEDIA_CONNECT)
- && (check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE) == true)) {
+ if ((media_status == RT_MEDIA_CONNECT) &&
+ (check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE) == true)) {
   rtw_hal_set_hwreg(padapter, HW_VAR_DL_RSVD_PAGE, NULL);
  }

@@ -65,7 +65,6 @@ void rtw_btcoex_LPS_Leave(struct adapter *padapter)
 {
  struct pwrctrl_priv *pwrpriv;

-
  pwrpriv = adapter_to_pwrctl(padapter);

  if (pwrpriv->pwr_mode != PS_MODE_ACTIVE) {
diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c
b/drivers/staging/rtl8723bs/core/rtw_efuse.c
index 099320e4e..fb3905cfd 100644
--- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
@@ -76,8 +76,9 @@ u16 Address)
     break;
   }
   return rtw_read8(Adapter, EFUSE_CTRL);
- } else
+ } else {
   return 0xFF;
+ }

 } /* EFUSE_Read1Byte */

@@ -232,7 +233,6 @@ void EFUSE_ShadowMapUpdate(struct adapter
*padapter, u8 efuseType)
  /* void *)&pHalData->EfuseMap[EFUSE_INIT_MAP][0], mapLen); */
 } /* EFUSE_ShadowMapUpdate */

-
 /*-----------------------------------------------------------------------------
  * Function: EFUSE_ShadowRead
  *
diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
index c70541f95..fa79c1928 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
@@ -36,11 +36,11 @@ u8 rtw_do_join(struct adapter *padapter)
 {
  struct list_head *plist, *phead;
  u8 *pibss = NULL;
- struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
- struct __queue *queue = &(pmlmepriv->scanned_queue);
+ struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
+ struct __queue *queue = &pmlmepriv->scanned_queue;
  u8 ret = _SUCCESS;

- spin_lock_bh(&(pmlmepriv->scanned_queue.lock));
+ spin_lock_bh(&pmlmepriv->scanned_queue.lock);
  phead = get_list_head(queue);
  plist = get_next(phead);

@@ -53,7 +53,7 @@ u8 rtw_do_join(struct adapter *padapter)
  pmlmepriv->to_join = true;

  if (list_empty(&queue->queue)) {
- spin_unlock_bh(&(pmlmepriv->scanned_queue.lock));
+ spin_unlock_bh(&pmlmepriv->scanned_queue.lock);
   _clr_fwstate_(pmlmepriv, _FW_UNDER_LINKING);

   /* when set_ssid/set_bssid for rtw_do_join(), but scanning queue is empty */
@@ -74,7 +74,7 @@ u8 rtw_do_join(struct adapter *padapter)
  } else {
   int select_ret;

- spin_unlock_bh(&(pmlmepriv->scanned_queue.lock));
+ spin_unlock_bh(&pmlmepriv->scanned_queue.lock);
   select_ret = rtw_select_and_join_from_scanned_queue(pmlmepriv);
   if (select_ret == _SUCCESS) {
    pmlmepriv->to_join = false;
@@ -84,7 +84,7 @@ u8 rtw_do_join(struct adapter *padapter)
     /* submit createbss_cmd to change to a ADHOC_MASTER */

     /* pmlmepriv->lock has been acquired by caller... */
- struct wlan_bssid_ex *pdev_network = &(padapter->registrypriv.dev_network);
+ struct wlan_bssid_ex *pdev_network = &padapter->registrypriv.dev_network;

     pmlmepriv->fw_state = WIFI_ADHOC_MASTER_STATE;

@@ -151,7 +151,7 @@ u8 rtw_set_802_11_ssid(struct adapter *padapter,
struct ndis_802_11_ssid *ssid)
  else if (check_fwstate(pmlmepriv, _FW_UNDER_LINKING) == true)
   goto release_mlme_lock;

- if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) == true) {
+ if (check_fwstate(pmlmepriv, _FW_LINKED | WIFI_ADHOC_MASTER_STATE) == true) {
   if ((pmlmepriv->assoc_ssid.ssid_length == ssid->ssid_length) &&
       (!memcmp(&pmlmepriv->assoc_ssid.ssid, ssid->ssid, ssid->ssid_length))) {
    if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) == false) {
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c
b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index 9f21a2226..84314b7f6 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -342,8 +342,8 @@ bool rtw_is_same_ibss(struct adapter *adapter,
struct wlan_network *pnetwork)

 inline int is_same_ess(struct wlan_bssid_ex *a, struct wlan_bssid_ex *b)
 {
- return (a->ssid.ssid_length == b->ssid.ssid_length)
- && !memcmp(a->ssid.ssid, b->ssid.ssid, a->ssid.ssid_length);
+ return (a->ssid.ssid_length == b->ssid.ssid_length) &&
+ !memcmp(a->ssid.ssid, b->ssid.ssid, a->ssid.ssid_length);
 }

 int is_same_network(struct wlan_bssid_ex *src, struct wlan_bssid_ex
*dst, u8 feature)
-- 
2.47.3

Re: [PATCH] staging: rtl8723bs: fix checkpatch style issues

[gregkh]

On Sat, Jun 20, 2026 at 08:41:12PM -0300, Saulo Henrique wrote:
> >From 66175877cefddce1a2ea5ee2cffec427c05b21d2 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Saulo=20Henrique=20Santos=20Dorot=C3=A9io?=
>  <doroteios@outlook.com>
> Date: Sat, 20 Jun 2026 19:29:24 -0300
> Subject: [PATCH] staging: rtl8723bs: fix checkpatch style issues
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> Fix multiple coding styles issues reported by checkpatch.pl, including
> line wrapping and whitespace cleanup.
> 
> Signed-off-by: Saulo Henrique Santos Dorotéio <doroteios@outlook.com>

You sent this 5 times?  Also, the header shouldn't be in the body like
this, please use git send-email or b4 to send this type of thing out.

thanks,

greg k-h