Linux kernel staging patches
 help / color / mirror / Atom feed
* [PATCH] staging: rtl8723bs: fix CamelCase warnings for bResult and Address in rtw_efuse.c
@ 2026-06-23  8:56 Bruce Ou
  2026-07-07 11:27 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 2+ messages in thread
From: Bruce Ou @ 2026-06-23  8:56 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: linux-staging, linux-kernel, Bruce Ou

Signed-off-by: Bruce Ou <oubruce1234@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_efuse.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
index b5dc5892f..355ac2004 100644
--- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
@@ -44,7 +44,7 @@ Efuse_CalculateWordCnts(u8 word_en)
 u8
 EFUSE_Read1Byte(
 struct adapter *Adapter,
-u16		Address)
+u16		address)
 {
 	u8 byte_temp = {0x00};
 	u8 temp = {0x00};
@@ -53,13 +53,13 @@ u16		Address)
 
 	Hal_GetEfuseDefinition(Adapter, EFUSE_WIFI, TYPE_EFUSE_REAL_CONTENT_LEN, &content_len);
 
-	if (Address < content_len) {/* E-fuse 512Byte */
+	if (address < content_len) {/* E-fuse 512Byte */
 		/* Write E-fuse Register address bit0~7 */
-		temp = Address & 0xFF;
+		temp = address & 0xFF;
 		rtw_write8(Adapter, EFUSE_CTRL + 1, temp);
 		byte_temp = rtw_read8(Adapter, EFUSE_CTRL + 2);
 		/* Write E-fuse Register address bit8~9 */
-		temp = ((Address >> 8) & 0x03) | (byte_temp & 0xFC);
+		temp = ((address >> 8) & 0x03) | (byte_temp & 0xFC);
 		rtw_write8(Adapter, EFUSE_CTRL + 2, temp);
 
 		/* Write 0x30[31]= 0 */
@@ -89,7 +89,7 @@ u16	addr,
 u8	*data)
 {
 	u32 tmpidx = 0;
-	u8 bResult;
+	u8 result;
 	u8 readbyte;
 
 	/*  <20130121, Kordan> For SMIC EFUSE specificatoin. */
@@ -114,13 +114,13 @@ u8	*data)
 	}
 	if (tmpidx < 100) {
 		*data = rtw_read8(padapter, EFUSE_CTRL);
-		bResult = true;
+		result = true;
 	} else {
 		*data = 0xff;
-		bResult = false;
+		result = false;
 	}
 
-	return bResult;
+	return result;
 }
 
 /*-----------------------------------------------------------------------------
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: rtl8723bs: fix CamelCase warnings for bResult and Address in rtw_efuse.c
  2026-06-23  8:56 [PATCH] staging: rtl8723bs: fix CamelCase warnings for bResult and Address in rtw_efuse.c Bruce Ou
@ 2026-07-07 11:27 ` Greg Kroah-Hartman
  0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2026-07-07 11:27 UTC (permalink / raw)
  To: Bruce Ou; +Cc: linux-staging, linux-kernel

On Tue, Jun 23, 2026 at 04:56:49PM +0800, Bruce Ou wrote:
> Signed-off-by: Bruce Ou <oubruce1234@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_efuse.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> index b5dc5892f..355ac2004 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> @@ -44,7 +44,7 @@ Efuse_CalculateWordCnts(u8 word_en)
>  u8
>  EFUSE_Read1Byte(
>  struct adapter *Adapter,
> -u16		Address)
> +u16		address)
>  {
>  	u8 byte_temp = {0x00};
>  	u8 temp = {0x00};
> @@ -53,13 +53,13 @@ u16		Address)
>  
>  	Hal_GetEfuseDefinition(Adapter, EFUSE_WIFI, TYPE_EFUSE_REAL_CONTENT_LEN, &content_len);
>  
> -	if (Address < content_len) {/* E-fuse 512Byte */
> +	if (address < content_len) {/* E-fuse 512Byte */
>  		/* Write E-fuse Register address bit0~7 */
> -		temp = Address & 0xFF;
> +		temp = address & 0xFF;
>  		rtw_write8(Adapter, EFUSE_CTRL + 1, temp);
>  		byte_temp = rtw_read8(Adapter, EFUSE_CTRL + 2);
>  		/* Write E-fuse Register address bit8~9 */
> -		temp = ((Address >> 8) & 0x03) | (byte_temp & 0xFC);
> +		temp = ((address >> 8) & 0x03) | (byte_temp & 0xFC);
>  		rtw_write8(Adapter, EFUSE_CTRL + 2, temp);
>  
>  		/* Write 0x30[31]= 0 */
> @@ -89,7 +89,7 @@ u16	addr,
>  u8	*data)
>  {
>  	u32 tmpidx = 0;
> -	u8 bResult;
> +	u8 result;

This should now be a boolean, right?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-07-07 11:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-23  8:56 [PATCH] staging: rtl8723bs: fix CamelCase warnings for bResult and Address in rtw_efuse.c Bruce Ou
2026-07-07 11:27 ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox