From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Arnav Kapoor <kapoorarnav43@gmail.com>
Cc: Johan Hovold <johan@kernel.org>,
linux-staging@lists.linux.dev, greybus-dev@lists.linaro.org
Subject: Re: [staging] staging: greybus: loopback: add missing comment for mutex
Date: Tue, 7 Jul 2026 11:01:23 +0200 [thread overview]
Message-ID: <2026070754-lumber-raking-ea19@gregkh> (raw)
In-Reply-To: <20260622042721.31760-1-kapoorarnav43@gmail.com>
On Mon, Jun 22, 2026 at 09:57:21AM +0530, Arnav Kapoor wrote:
> Add a comment for the mutex as suggested by checkpatch.
>
> Signed-off-by: Arnav Kapoor <kapoorarnav43@gmail.com>
The subject line should have [PATCH] in it, right?
> ---
> drivers/staging/greybus/loopback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
> index ea57b1f5d..bf827e672 100644
> --- a/drivers/staging/greybus/loopback.c
> +++ b/drivers/staging/greybus/loopback.c
> @@ -61,7 +61,7 @@ struct gb_loopback {
>
> struct dentry *file;
> struct kfifo kfifo_lat;
> - struct mutex mutex;
> + struct mutex mutex; /* protects the entire structure */
Look on the mailing list for other places where this type of change was
rejected as it doesn't really explain anything.
thanks,
greg k-h
prev parent reply other threads:[~2026-07-07 9:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-22 4:27 [staging] staging: greybus: loopback: add missing comment for mutex Arnav Kapoor
2026-07-07 9:01 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026070754-lumber-raking-ea19@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=kapoorarnav43@gmail.com \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox