* [staging] staging: greybus: loopback: add missing comment for mutex
@ 2026-06-22 4:27 Arnav Kapoor
2026-07-07 9:01 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Arnav Kapoor @ 2026-06-22 4:27 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Johan Hovold, linux-staging, greybus-dev, Arnav Kapoor
Add a comment for the mutex as suggested by checkpatch.
Signed-off-by: Arnav Kapoor <kapoorarnav43@gmail.com>
---
drivers/staging/greybus/loopback.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
index ea57b1f5d..bf827e672 100644
--- a/drivers/staging/greybus/loopback.c
+++ b/drivers/staging/greybus/loopback.c
@@ -61,7 +61,7 @@ struct gb_loopback {
struct dentry *file;
struct kfifo kfifo_lat;
- struct mutex mutex;
+ struct mutex mutex; /* protects the entire structure */
struct task_struct *task;
struct device *dev;
wait_queue_head_t wq;
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [staging] staging: greybus: loopback: add missing comment for mutex
2026-06-22 4:27 [staging] staging: greybus: loopback: add missing comment for mutex Arnav Kapoor
@ 2026-07-07 9:01 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2026-07-07 9:01 UTC (permalink / raw)
To: Arnav Kapoor; +Cc: Johan Hovold, linux-staging, greybus-dev
On Mon, Jun 22, 2026 at 09:57:21AM +0530, Arnav Kapoor wrote:
> Add a comment for the mutex as suggested by checkpatch.
>
> Signed-off-by: Arnav Kapoor <kapoorarnav43@gmail.com>
The subject line should have [PATCH] in it, right?
> ---
> drivers/staging/greybus/loopback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
> index ea57b1f5d..bf827e672 100644
> --- a/drivers/staging/greybus/loopback.c
> +++ b/drivers/staging/greybus/loopback.c
> @@ -61,7 +61,7 @@ struct gb_loopback {
>
> struct dentry *file;
> struct kfifo kfifo_lat;
> - struct mutex mutex;
> + struct mutex mutex; /* protects the entire structure */
Look on the mailing list for other places where this type of change was
rejected as it doesn't really explain anything.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-07 9:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-22 4:27 [staging] staging: greybus: loopback: add missing comment for mutex Arnav Kapoor
2026-07-07 9:01 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox